Add billing samples (Node 8 ONLY) #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
fhinkel
reviewed
Sep 24, 2018
| const {google} = require('googleapis'); | ||
| const {auth} = require('google-auth-library'); | ||
|
|
||
| const PROJECT_ID = process.env.GCP_PROJECT; |
There was a problem hiding this comment.
I think GCP_PROJECT is not a variable we usually set. Can we use the standard mechanism instead?
There was a problem hiding this comment.
It is defined (and named) by GCF itself.
fhinkel
reviewed
Sep 24, 2018
fhinkel
reviewed
Sep 24, 2018
|
|
||
| exports.stopBilling = async (data, context) => { | ||
| const pubsubData = JSON.parse(Buffer.from(data.data, 'base64').toString()); | ||
| if (pubsubData.costAmount <= pubsubData.budgetAmount) { |
There was a problem hiding this comment.
Do we need to assure that costAmount is a number and not a string? Want to avoid cases like '100' < '2' = true
There was a problem hiding this comment.
Probably not - the Billing API itself outputs a number, not a string.
FWIW this is how the code is currently structured.
fhinkel
suggested changes
Sep 24, 2018
|
CI (config) has been added - PTAL? |
fhinkel
approved these changes
Sep 25, 2018
This was referenced Mar 7, 2020
ace-n
pushed a commit
that referenced
this pull request
Nov 16, 2022
* chore(main): release 4.1.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
* chore(main): release 4.1.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 17, 2022
* chore(main): release 4.1.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@labtopia FYI