Add gcp-build samples #710

ace-n · 2018-08-14T01:24:01Z

Do not merge - this is missing a (TypeScript) sample.

codecov · 2018-08-14T01:24:06Z

Codecov Report

Merging #710 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #710   +/-   ##
=======================================
  Coverage   55.17%   55.17%           
=======================================
  Files           1        1           
  Lines          58       58           
=======================================
  Hits           32       32           
  Misses         26       26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2581b47...2c52716. Read the comment docs.

steren · 2018-08-14T02:18:42Z

Can you add a README.md explaining what the sample does and what is happening when gcp-build is run?

steren · 2018-08-14T02:19:53Z

appengine/uglifyjs/static/index_min.html

+    <script src="message.min.js" type="text/javascript"></script>
+    <link rel="stylesheet" href="style.min.css">
+  </head>
+  <body>


Maybe add as a visible text to this page that this is loading minified resources.

Ditto to below comment.

steren · 2018-08-14T02:20:22Z

appengine/uglifyjs/static/index.html

+    <script src="message.js" type="text/javascript"></script>
+    <link rel="stylesheet" href="style.css">
+  </head>
+  <body>


Maybe add as a visible text to this page that this is loading unminified resources?

I feel like this should be obvious based on the different page URLs (/index vs /index_min)

steren · 2018-08-14T22:32:45Z

appengine/typescript/index.ts

+
+/* tslint:disable:no-console no-var-requires */
+
+declare var require: any;


I think we can do better as a TS example.
This seems to be the copy paste of my little experiement, but does not feel very TS idiomatic: for example, the Express types should be loaded from npm and I would expect the function to use typed objects.

Yes, it is largely a copy-paste as I'm not terribly familiar with Typescript 😛

@JustinBeckwith is our resident TS expert, so I'll see what he suggests.

steren · 2018-08-14T22:33:24Z

appengine/typescript/app.yaml

@@ -0,0 +1,7 @@
+runtime: nodejs8
+
+handlers:


remove handlers, they are optional.

Did you push the commit?

fhinkel · 2018-08-16T18:46:36Z

appengine/typescript/README.md

+
+        npm install
+
+    or with `yarn`:


Personal preference, I would not include yarn here. Our Node docs say that you can use npm or yarn, no need to show everything twice here.

Removed yarn for brevity.

fhinkel

Can you add tests for those samples?

fhinkel · 2018-08-20T17:35:38Z

Thanks for adding tests, can you add them to kokoro, too?

ace-n · 2018-08-21T20:48:35Z

Done - should we merge this first, or the Kokoro stuff?

🤖 I have created a release \*beep\* \*boop\* --- ### [6.2.7](https://www.github.com/googleapis/nodejs-translate/compare/v6.2.6...v6.2.7) (2021-08-17) ### Bug Fixes * **deps:** google-gax v2.24.1 ([#711](https://www.github.com/googleapis/nodejs-translate/issues/711)) ([87604a3](https://www.github.com/googleapis/nodejs-translate/commit/87604a30f57186c90e8edfe7a3259c41da8c03d2)) * increase timeout for batch translate document ([#708](https://www.github.com/googleapis/nodejs-translate/issues/708)) ([ef154ad](https://www.github.com/googleapis/nodejs-translate/commit/ef154ad287820890a4aaedbf40e91b1cb2f798cc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Add uglifyjs sample

50bbc20

ace-n added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 14, 2018

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 14, 2018

Add GAE configs + tweak app description

e07b3e4

steren reviewed Aug 14, 2018

View reviewed changes

Ace Nassri added 3 commits August 14, 2018 11:57

Initial commit of Typescript sample

cca79ce

Address Steren's comments

8ab351e

Add READMEs

76d2c2a

ace-n requested a review from jmdobry August 14, 2018 21:31

steren reviewed Aug 14, 2018

View reviewed changes

ace-n requested a review from JustinBeckwith August 15, 2018 00:07

Remove handlers

a51b060

ace-n requested review from jkwlui and removed request for JustinBeckwith August 15, 2018 18:56

jkwlui and others added 2 commits August 15, 2018 12:16

Merge branch 'master' into gcp-build

24e8d4f

Use (more) idiomatic typescript

28652a9

ace-n removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 16, 2018

fhinkel reviewed Aug 16, 2018

View reviewed changes

fhinkel suggested changes Aug 16, 2018

View reviewed changes

Ace Nassri added 2 commits August 17, 2018 16:51

Remove yarn

bdd8076

Add repo-tools tests

8caaccd

JustinBeckwith and others added 2 commits August 20, 2018 10:39

Merge branch 'master' into gcp-build

36262e8

Add Kokoro test configs

9792a12

ace-n added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 21, 2018

Merge branch 'master' into gcp-build

6eaefb9

snyk-bot mentioned this pull request Aug 17, 2020

[Snyk] Security upgrade @google-cloud/storage from 1.3.0 to 3.0.0 ninadhatkar/nodejs-docs-samples#20

Open

ace-n mentioned this pull request Nov 17, 2022

migrate code from googleapis/nodejs-translate #2862

Merged

leejh3224 mentioned this pull request Jun 20, 2023

[Snyk] Security upgrade @google-cloud/storage from 2.5.0 to 3.0.0 leejh3224/nodejs-docs-samples#575

Open

pedroarapua mentioned this pull request Jun 20, 2023

[Snyk] Security upgrade @google-cloud/storage from 2.5.0 to 3.0.0 pedroarapua/nodejs-docs-samples-gcp#384

Open

leejh3224 mentioned this pull request Jun 20, 2023

[Snyk] Fix for 1 vulnerabilities leejh3224/nodejs-docs-samples#576

Open

pedroarapua mentioned this pull request Jun 20, 2023

[Snyk] Security upgrade @google-cloud/storage from 2.5.0 to 3.0.0 pedroarapua/nodejs-docs-samples-gcp#385

Open

leejh3224 mentioned this pull request Jun 21, 2023

[Snyk] Fix for 1 vulnerabilities leejh3224/nodejs-docs-samples#591

Open

This was referenced Jul 6, 2023

[Snyk] Security upgrade @google-cloud/logging-winston from 0.11.1 to 5.0.0 pedroarapua/nodejs-docs-samples-gcp#417

Open

[Snyk] Security upgrade @google-cloud/logging-winston from 0.11.1 to 5.0.0 pedroarapua/nodejs-docs-samples-gcp#421

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add gcp-build samples #710

Add gcp-build samples #710

ace-n commented Aug 14, 2018 •

edited

Loading

codecov bot commented Aug 14, 2018 •

edited

Loading

steren commented Aug 14, 2018

steren Aug 14, 2018

ace-n Aug 14, 2018

steren Aug 14, 2018

ace-n Aug 14, 2018

steren Aug 14, 2018 •

edited

Loading

ace-n Aug 15, 2018

steren Aug 14, 2018

ace-n Aug 15, 2018

steren Aug 15, 2018

fhinkel Aug 16, 2018

ace-n Aug 17, 2018

fhinkel left a comment

fhinkel commented Aug 20, 2018

ace-n commented Aug 21, 2018 •

edited

Loading


		/* tslint:disable:no-console no-var-requires */

		declare var require: any;

Add gcp-build samples #710

Add gcp-build samples #710

Conversation

ace-n commented Aug 14, 2018 • edited Loading

codecov bot commented Aug 14, 2018 • edited Loading

Codecov Report

steren commented Aug 14, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

steren Aug 14, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fhinkel left a comment

Choose a reason for hiding this comment

fhinkel commented Aug 20, 2018

ace-n commented Aug 21, 2018 • edited Loading

ace-n commented Aug 14, 2018 •

edited

Loading

codecov bot commented Aug 14, 2018 •

edited

Loading

steren Aug 14, 2018 •

edited

Loading

ace-n commented Aug 21, 2018 •

edited

Loading