Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tasks samples #703

Merged
merged 2 commits into from
Aug 3, 2018
Merged

Remove tasks samples #703

merged 2 commits into from
Aug 3, 2018

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented Aug 3, 2018

Now that the docs use the samples in the googleapis repo, we can get rid of these.

Do not merge until the cloudtasks test config has been removed internally.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 3, 2018
@averikitsch
Copy link
Contributor

Do you need to delete the Kokoro (cloudtasks.cfg) file too?

@ace-n
Copy link
Contributor Author

ace-n commented Aug 3, 2018

@averikitsch Not strictly necessary AFAIK, but good catch nonetheless. 😄

@ace-n ace-n added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 3, 2018
@codecov
Copy link

codecov bot commented Aug 3, 2018

Codecov Report

Merging #703 into master will decrease coverage by 6.64%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #703      +/-   ##
==========================================
- Coverage   55.17%   48.52%   -6.65%     
==========================================
  Files           1        1              
  Lines          58       68      +10     
==========================================
+ Hits           32       33       +1     
- Misses         26       35       +9
Impacted Files Coverage Δ
functions/tips/index.js 48.52% <0%> (-6.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bb14ef...26810fa. Read the comment docs.

@ace-n ace-n removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 3, 2018
@ace-n ace-n merged commit ccdd400 into master Aug 3, 2018
@ace-n ace-n deleted the delete-tasks branch August 3, 2018 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants