puppeteer sample (Headless Chrome) #625

steren · 2018-05-25T14:54:36Z

No description provided.

codecov · 2018-05-29T16:14:27Z

Codecov Report

Merging #625 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #625   +/-   ##
=======================================
  Coverage   48.52%   48.52%           
=======================================
  Files           1        1           
  Lines          68       68           
=======================================
  Hits           33       33           
  Misses         35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fc023b...c80a5f2. Read the comment docs.

fhinkel · 2018-06-04T23:45:50Z

appengine/headless-chrome/test/app.test.js

+const cwd = path.join(__dirname, `../`);
+const requestObj = utils.getRequest({ cwd: cwd });
+
+test.serial.cb(`should return a screenshot`, (t) => {


Can you remove the extra () when it's just one parameter and {} when it's just one statement please.

done for (), I tried to remove the {} but tests fail.

fhinkel · 2018-06-04T23:46:46Z

appengine/headless-chrome/README.md

+
+## Running locally
+
+* Install dependencies with `npm install` (Headless Chrome will take some time to download)


I think we either need a period or extra line breaks here or this will look weird.

I am not sure what you mean. This is just one line in a bullet point. I added a comma at the end.

fhinkel · 2018-06-04T23:53:06Z

appengine/headless-chrome/package.json

+  "description": "An example of taking screenshot with Puppeteer (Headless Chrome) in Node.js on Google App Engine.",
+  "scripts": {
+    "start": "node app.js",
+    "system-test": "repo-tools test app",


We only have one test but we're using it both as system-test and as unit-test 😉 It should be run as one or the other.

I am not sure I understand your comment. Can you be more specific about what I should do?

We have 2 different kind of tests runnign here. both of them are run when running nom run test

But there's only one test file with one test. Where's the second test?

Please compare to the other samples in this repository, I tried to mimic the architecture as much as possible.
The test run with system-test is defined in package.json in cloud-repo-tools

See for example https://github.com/GoogleCloudPlatform/nodejs-docs-samples/tree/master/appengine/pubsub

That also has these two tests.

fhinkel · 2018-06-04T23:56:14Z

appengine/headless-chrome/test/app.test.js

+const requestObj = utils.getRequest({ cwd: cwd });
+
+test.serial.cb(`should return a screenshot`, (t) => {
+  requestObj


Currently, this test does not test the sample. I'd expect something like require('./app.js') in the test. Then the test can start the server from the sample, send a request and do the checks like you have, and shut down the server.

It does tests and the test passes.

I think the magic happens with requestObj.

fhinkel · 2018-06-04T23:59:01Z

appengine/headless-chrome/README.md

@@ -0,0 +1,12 @@
+# Headless Chrome on Google App Engine
+
+This sample application demonstrates how to use Headless Chrome via the [Puppeteer](https://developers.google.com/web/tools/puppeteer/) module to take screenshots of webpages on [Google App Engine](https://cloud.google.com/appengine) Node.js [standard environment](https://cloud.google.com/appengine/docs/standard/nodejs).


I think the prerequisites are missing here. Do we not link to the gcloud "Before you get started" section in these samples?

No we do not.
But I am happy to add it.

"Refer to the appengine/README.md file for more instructions on running and deploying this app" is the sentence most examples in the repo use. Can we do the same? Then we also have the section on credentials.

Sounds good, I just pushed a change that point to the main README

fhinkel

Please have a look at the comments.

fhinkel · 2018-06-05T10:04:20Z

appengine/headless-chrome/test/app.test.js

+    .get(`/?url=https://example.com`)
+    .send()
+    .expect(200)
+    .expect((response) => {


Please remove the extra () if it's a single parameter.

fhinkel · 2018-06-05T17:27:34Z

appengine/headless-chrome/package.json

+    "puppeteer": "^1.2.0"
+  },
+  "devDependencies": {
+    "@google-cloud/nodejs-repo-tools": "2.2.1",


Any reason we're not using 2.3.0?

* build!: Update library to use Node 12 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* feat!: Update library to use Node 12 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [mocha](https://mochajs.org/) ([source](https://togithub.com/mochajs/mocha)) | devDependencies | major | [`^7.0.0` -> `^8.0.0`](https://renovatebot.com/diffs/npm/mocha/7.2.0/8.0.1) | --- ### Release Notes <details> <summary>mochajs/mocha</summary> ### [`v8.0.1`](https://togithub.com/mochajs/mocha/blob/master/CHANGELOG.md#801--2020-06-10) [Compare Source](https://togithub.com/mochajs/mocha/compare/v8.0.0...v8.0.1) The obligatory patch after a major. #### 🐛 Fixes - [#4328](https://togithub.com/mochajs/mocha/issues/4328): Fix `--parallel` when combined with `--watch` ([**@boneskull**](https://togithub.com/boneskull)) ### [`v8.0.0`](https://togithub.com/mochajs/mocha/blob/master/CHANGELOG.md#800--2020-06-10) [Compare Source](https://togithub.com/mochajs/mocha/compare/v7.2.0...v8.0.0) In this major release, Mocha adds the ability to _run tests in parallel_. Better late than never! Please note the **breaking changes** detailed below. Let's welcome [**@giltayar**](https://togithub.com/giltayar) and [**@nicojs**](https://togithub.com/nicojs) to the maintenance team! #### 💥 Breaking Changes - [#4164](https://togithub.com/mochajs/mocha/issues/4164): **Mocha v8.0.0 now requires Node.js v10.0.0 or newer.** Mocha no longer supports the Node.js v8.x line ("Carbon"), which entered End-of-Life at the end of 2019 ([**@UlisesGascon**](https://togithub.com/UlisesGascon)) - [#4175](https://togithub.com/mochajs/mocha/issues/4175): Having been deprecated with a warning since v7.0.0, **`mocha.opts` is no longer supported** ([**@juergba**](https://togithub.com/juergba)) ✨ **WORKAROUND:** Replace `mocha.opts` with a [configuration file](https://mochajs.org/#configuring-mocha-nodejs). - [#4260](https://togithub.com/mochajs/mocha/issues/4260): Remove `enableTimeout()` (`this.enableTimeout()`) from the context object ([**@craigtaub**](https://togithub.com/craigtaub)) ✨ **WORKAROUND:** Replace usage of `this.enableTimeout(false)` in your tests with `this.timeout(0)`. - [#4315](https://togithub.com/mochajs/mocha/issues/4315): The `spec` option no longer supports a comma-delimited list of files ([**@juergba**](https://togithub.com/juergba)) ✨ **WORKAROUND**: Use an array instead (e.g., `"spec": "foo.js,bar.js"` becomes `"spec": ["foo.js", "bar.js"]`). - [#4309](https://togithub.com/mochajs/mocha/issues/4309): Drop support for Node.js v13.x line, which is now End-of-Life ([**@juergba**](https://togithub.com/juergba)) - [#4282](https://togithub.com/mochajs/mocha/issues/4282): `--forbid-only` will throw an error even if exclusive tests are avoided via `--grep` or other means ([**@arvidOtt**](https://togithub.com/arvidOtt)) - [#4223](https://togithub.com/mochajs/mocha/issues/4223): The context object's `skip()` (`this.skip()`) in a "before all" (`before()`) hook will no longer execute subsequent sibling hooks, in addition to hooks in child suites ([**@juergba**](https://togithub.com/juergba)) - [#4178](https://togithub.com/mochajs/mocha/issues/4178): Remove previously soft-deprecated APIs ([**@wnghdcjfe**](https://togithub.com/wnghdcjfe)): - `Mocha.prototype.ignoreLeaks()` - `Mocha.prototype.useColors()` - `Mocha.prototype.useInlineDiffs()` - `Mocha.prototype.hideDiff()` #### 🎉 Enhancements - [#4245](https://togithub.com/mochajs/mocha/issues/4245): Add ability to run tests in parallel for Node.js (see [docs](https://mochajs.org/#parallel-tests)) ([**@boneskull**](https://togithub.com/boneskull)) ❗ See also [#4244](https://togithub.com/mochajs/mocha/issues/4244); [Root Hook Plugins (docs)](https://mochajs.org/#root-hook-plugins) -- _root hooks must be defined via Root Hook Plugins to work in parallel mode_ - [#4304](https://togithub.com/mochajs/mocha/issues/4304): `--require` now works with ES modules ([**@JacobLey**](https://togithub.com/JacobLey)) - [#4299](https://togithub.com/mochajs/mocha/issues/4299): In some circumstances, Mocha can run ES modules under Node.js v10 -- _use at your own risk!_ ([**@giltayar**](https://togithub.com/giltayar)) #### 📖 Documentation - [#4246](https://togithub.com/mochajs/mocha/issues/4246): Add documentation for parallel mode and Root Hook plugins ([**@boneskull**](https://togithub.com/boneskull)) #### 🐛 Fixes (All bug fixes in Mocha v8.0.0 are also breaking changes, and are listed above) </details> --- ### Renovate configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻️ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/nodejs-dialogflow).

steren added 5 commits May 25, 2018 16:53

puppeteer sample (Headless Chrome)

a6b9c28

Fix snippet name

f40b442

newline for app.yaml

9708edc

update test to use server instead of app

ecf1f20

Use app.js to fix cloud-repo-tools error

6c05d34

ace-n requested a review from fhinkel May 30, 2018 23:43

steren added 2 commits June 1, 2018 17:14

Add test for screenshot

9cae70e

Update browser snippet

8638c40

fhinkel reviewed Jun 4, 2018

View reviewed changes

steren added 3 commits June 4, 2018 18:08

Remove unecessary ()

d478a66

Update README

1d00f38

Fix typo

a610c3f

fhinkel reviewed Jun 5, 2018

View reviewed changes

steren added 3 commits June 5, 2018 08:57

Merge branch 'master' into master

4fc6f91

Merge branch 'master' of github.com:steren/nodejs-docs-samples

833f322

Remove unecessary ()

cf566d6

fhinkel reviewed Jun 5, 2018

View reviewed changes

fhinkel approved these changes Jun 5, 2018

View reviewed changes

steren added 4 commits June 5, 2018 13:01

Use app.standard.yaml

2a584ed

Update @google-cloud/nodejs-repo-tools dep

e7616bb

point to GAE instructions for local run and deployment

dcc642e

Merge branch 'master' into master

c80a5f2

fhinkel merged commit 348916f into GoogleCloudPlatform:master Jun 5, 2018

snyk-bot mentioned this pull request Dec 23, 2020

[Snyk] Security upgrade @google-cloud/debug-agent from 3.0.1 to 3.1.0 leejh3224/nodejs-docs-samples#286

Open

snyk-bot mentioned this pull request Sep 6, 2021

[Snyk] Security upgrade @google-cloud/debug-agent from 3.0.1 to 3.1.0 leejh3224/nodejs-docs-samples#367

Open

snyk-bot mentioned this pull request Jan 12, 2022

[Snyk] Security upgrade @google-cloud/debug-agent from 3.0.1 to 3.1.0 leejh3224/nodejs-docs-samples#439

Open

snyk-bot mentioned this pull request Feb 10, 2022

[Snyk] Security upgrade @google-cloud/debug-agent from 3.0.1 to 3.1.0 leejh3224/nodejs-docs-samples#450

Open

grayside pushed a commit that referenced this pull request Oct 26, 2022

build!: update library to use Node 12 (#625)

601846c

* build!: Update library to use Node 12 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

grayside mentioned this pull request Oct 26, 2022

migrate code from googleapis/nodejs-tasks #2792

Merged

grayside pushed a commit that referenced this pull request Nov 3, 2022

build!: update library to use Node 12 (#625)

76cbffe

* build!: Update library to use Node 12 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

ahrarmonsur pushed a commit that referenced this pull request Nov 8, 2022

chore(main): release 3.0.1 (#625)

ade5440

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

ahrarmonsur mentioned this pull request Nov 8, 2022

samples: migrate code from googleapis/nodejs-monitoring #2807

Merged

ace-n pushed a commit that referenced this pull request Nov 10, 2022

chore(main): release 3.0.1 (#625)

cba101a

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

ahrarmonsur mentioned this pull request Nov 16, 2022

migrate code from googleapis/nodejs-asset #2856

Merged

ahrarmonsur mentioned this pull request Nov 18, 2022

migrate code from googleapis/nodejs-dialogflow #2873

Merged

leejh3224 mentioned this pull request Oct 27, 2023

[Snyk] Security upgrade @google-cloud/debug-agent from 3.0.1 to 3.1.0 leejh3224/nodejs-docs-samples#620

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

puppeteer sample (Headless Chrome) #625

puppeteer sample (Headless Chrome) #625

steren commented May 25, 2018

codecov bot commented May 29, 2018 •

edited

Loading

fhinkel Jun 4, 2018

steren Jun 5, 2018

fhinkel Jun 4, 2018

steren Jun 5, 2018

fhinkel Jun 4, 2018

steren Jun 5, 2018

fhinkel Jun 5, 2018

steren Jun 5, 2018

steren Jun 5, 2018 •

edited

Loading

fhinkel Jun 4, 2018

steren Jun 5, 2018

fhinkel Jun 4, 2018

steren Jun 5, 2018

fhinkel Jun 5, 2018

steren Jun 5, 2018

fhinkel left a comment

fhinkel Jun 5, 2018

steren Jun 5, 2018

fhinkel Jun 5, 2018

steren Jun 5, 2018


		## Running locally

		* Install dependencies with `npm install` (Headless Chrome will take some time to download)

		@@ -0,0 +1,12 @@
		# Headless Chrome on Google App Engine

		This sample application demonstrates how to use Headless Chrome via the [Puppeteer](https://developers.google.com/web/tools/puppeteer/) module to take screenshots of webpages on [Google App Engine](https://cloud.google.com/appengine) Node.js [standard environment](https://cloud.google.com/appengine/docs/standard/nodejs).

puppeteer sample (Headless Chrome) #625

puppeteer sample (Headless Chrome) #625

Conversation

steren commented May 25, 2018

codecov bot commented May 29, 2018 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

steren Jun 5, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fhinkel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented May 29, 2018 •

edited

Loading

steren Jun 5, 2018 •

edited

Loading