Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant error listener from Redis client #601

Merged
merged 4 commits into from
Jun 12, 2018

Conversation

LewisJEllis
Copy link
Contributor

This is actually a memory leak, attaching an additional listener for each request, but the client already has an error listener.

@fhinkel
Copy link
Contributor

fhinkel commented Jun 5, 2018

@LewisJEllis Thank so much, good find! Sorry that this sat here for so long.

@codecov
Copy link

codecov bot commented Jun 12, 2018

Codecov Report

Merging #601 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #601   +/-   ##
=======================================
  Coverage   48.52%   48.52%           
=======================================
  Files           1        1           
  Lines          68       68           
=======================================
  Hits           33       33           
  Misses         35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f41e30...14a754a. Read the comment docs.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 12, 2018
@JustinBeckwith JustinBeckwith merged commit 30f7631 into GoogleCloudPlatform:master Jun 12, 2018
@LewisJEllis LewisJEllis deleted the patch-1 branch June 13, 2018 06:09
@LewisJEllis
Copy link
Contributor Author

Yay! Thanks :)

NimJay pushed a commit that referenced this pull request Nov 10, 2022
🤖 I have created a release \*beep\* \*boop\*
---
### [4.2.8](https://www.github.com/googleapis/nodejs-language/compare/v4.2.7...v4.2.8) (2021-07-21)


### Bug Fixes

* Updating WORKSPACE files to use the newest version of the Typescript generator. ([#600](https://www.github.com/googleapis/nodejs-language/issues/600)) ([9f31d3f](https://www.github.com/googleapis/nodejs-language/commit/9f31d3f510c1628d610633d4ec749abdf66d73f3))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
NimJay pushed a commit that referenced this pull request Nov 10, 2022
🤖 I have created a release \*beep\* \*boop\*
---
### [4.2.8](https://www.github.com/googleapis/nodejs-language/compare/v4.2.7...v4.2.8) (2021-07-21)


### Bug Fixes

* Updating WORKSPACE files to use the newest version of the Typescript generator. ([#600](https://www.github.com/googleapis/nodejs-language/issues/600)) ([9f31d3f](https://www.github.com/googleapis/nodejs-language/commit/9f31d3f510c1628d610633d4ec749abdf66d73f3))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants