-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the params sent across to the ga endpoint. #582
Conversation
spreading the results allows the endpoint to pick up the individual params. Previous method does not work. see https://developers.google.com/analytics/devguides/collection/protocol/v1/reference for more
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I have signed it! |
add semicolon
added the semicolon |
removed silly semi colon!
appengine/analytics/app.js
Outdated
@@ -48,7 +48,7 @@ function trackEvent (category, action, label, value, cb) { | |||
}; | |||
|
|||
return got.post('http://www.google-analytics.com/collect', { | |||
form: data | |||
...data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This operator only works in Node v8.6+, but we strive to make sure our samples work with the oldest LTS version of Node, which until the end of April is Node v4. Can you update your PR to be Node v4 compatible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jmdobry,
Makes sense, updated to use Object.assign instead.
🤖 I have created a release \*beep\* \*boop\* --- ## [2.5.0](https://www.github.com/googleapis/nodejs-tasks/compare/v2.4.2...v2.5.0) (2021-12-09) ### Features * add eslintignore for sameple generated code ([#1302](https://www.github.com/googleapis/nodejs-tasks/issues/1302)) ([#582](https://www.github.com/googleapis/nodejs-tasks/issues/582)) ([bf99e4e](https://www.github.com/googleapis/nodejs-tasks/commit/bf99e4ecc1c46cfd84893ef0ab097d27f26f9139)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release \*beep\* \*boop\* --- ## [2.5.0](https://www.github.com/googleapis/nodejs-tasks/compare/v2.4.2...v2.5.0) (2021-12-09) ### Features * add eslintignore for sameple generated code ([#1302](https://www.github.com/googleapis/nodejs-tasks/issues/1302)) ([#582](https://www.github.com/googleapis/nodejs-tasks/issues/582)) ([bf99e4e](https://www.github.com/googleapis/nodejs-tasks/commit/bf99e4ecc1c46cfd84893ef0ab097d27f26f9139)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [4.4.0](https://togithub.com/googleapis/nodejs-cloud-container/compare/v4.3.0...v4.4.0) (2022-11-10) ### Features * Add APIs for GKE Control Plane Logs ([#588](https://togithub.com/googleapis/nodejs-cloud-container/issues/588)) ([de62f0b](https://togithub.com/googleapis/nodejs-cloud-container/commit/de62f0bfc4d6972d1bbd48428ec2005ef2ccf890)) ### Bug Fixes * **deps:** Use google-gax v3.5.2 ([#582](https://togithub.com/googleapis/nodejs-cloud-container/issues/582)) ([3c62c1a](https://togithub.com/googleapis/nodejs-cloud-container/commit/3c62c1adbc913212097f50496e10c4ccfb6f2d86)) * Update proto definitions ([#586](https://togithub.com/googleapis/nodejs-cloud-container/issues/586)) ([dbee22e](https://togithub.com/googleapis/nodejs-cloud-container/commit/dbee22e4f5e793d1e1ebe5cec33edf2128963a60)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [4.4.0](https://togithub.com/googleapis/nodejs-cloud-container/compare/v4.3.0...v4.4.0) (2022-11-10) ### Features * Add APIs for GKE Control Plane Logs ([#588](https://togithub.com/googleapis/nodejs-cloud-container/issues/588)) ([de62f0b](https://togithub.com/googleapis/nodejs-cloud-container/commit/de62f0bfc4d6972d1bbd48428ec2005ef2ccf890)) ### Bug Fixes * **deps:** Use google-gax v3.5.2 ([#582](https://togithub.com/googleapis/nodejs-cloud-container/issues/582)) ([3c62c1a](https://togithub.com/googleapis/nodejs-cloud-container/commit/3c62c1adbc913212097f50496e10c4ccfb6f2d86)) * Update proto definitions ([#586](https://togithub.com/googleapis/nodejs-cloud-container/issues/586)) ([dbee22e](https://togithub.com/googleapis/nodejs-cloud-container/commit/dbee22e4f5e793d1e1ebe5cec33edf2128963a60)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [4.4.0](https://togithub.com/googleapis/nodejs-cloud-container/compare/v4.3.0...v4.4.0) (2022-11-10) ### Features * Add APIs for GKE Control Plane Logs ([#588](https://togithub.com/googleapis/nodejs-cloud-container/issues/588)) ([de62f0b](https://togithub.com/googleapis/nodejs-cloud-container/commit/de62f0bfc4d6972d1bbd48428ec2005ef2ccf890)) ### Bug Fixes * **deps:** Use google-gax v3.5.2 ([#582](https://togithub.com/googleapis/nodejs-cloud-container/issues/582)) ([3c62c1a](https://togithub.com/googleapis/nodejs-cloud-container/commit/3c62c1adbc913212097f50496e10c4ccfb6f2d86)) * Update proto definitions ([#586](https://togithub.com/googleapis/nodejs-cloud-container/issues/586)) ([dbee22e](https://togithub.com/googleapis/nodejs-cloud-container/commit/dbee22e4f5e793d1e1ebe5cec33edf2128963a60)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [4.4.0](https://togithub.com/googleapis/nodejs-cloud-container/compare/v4.3.0...v4.4.0) (2022-11-10) ### Features * Add APIs for GKE Control Plane Logs ([#588](https://togithub.com/googleapis/nodejs-cloud-container/issues/588)) ([de62f0b](https://togithub.com/googleapis/nodejs-cloud-container/commit/de62f0bfc4d6972d1bbd48428ec2005ef2ccf890)) ### Bug Fixes * **deps:** Use google-gax v3.5.2 ([#582](https://togithub.com/googleapis/nodejs-cloud-container/issues/582)) ([3c62c1a](https://togithub.com/googleapis/nodejs-cloud-container/commit/3c62c1adbc913212097f50496e10c4ccfb6f2d86)) * Update proto definitions ([#586](https://togithub.com/googleapis/nodejs-cloud-container/issues/586)) ([dbee22e](https://togithub.com/googleapis/nodejs-cloud-container/commit/dbee22e4f5e793d1e1ebe5cec33edf2128963a60)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [4.4.0](https://togithub.com/googleapis/nodejs-cloud-container/compare/v4.3.0...v4.4.0) (2022-11-10) ### Features * Add APIs for GKE Control Plane Logs ([#588](https://togithub.com/googleapis/nodejs-cloud-container/issues/588)) ([de62f0b](https://togithub.com/googleapis/nodejs-cloud-container/commit/de62f0bfc4d6972d1bbd48428ec2005ef2ccf890)) ### Bug Fixes * **deps:** Use google-gax v3.5.2 ([#582](https://togithub.com/googleapis/nodejs-cloud-container/issues/582)) ([3c62c1a](https://togithub.com/googleapis/nodejs-cloud-container/commit/3c62c1adbc913212097f50496e10c4ccfb6f2d86)) * Update proto definitions ([#586](https://togithub.com/googleapis/nodejs-cloud-container/issues/586)) ([dbee22e](https://togithub.com/googleapis/nodejs-cloud-container/commit/dbee22e4f5e793d1e1ebe5cec33edf2128963a60)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [4.4.0](https://togithub.com/googleapis/nodejs-cloud-container/compare/v4.3.0...v4.4.0) (2022-11-10) ### Features * Add APIs for GKE Control Plane Logs ([#588](https://togithub.com/googleapis/nodejs-cloud-container/issues/588)) ([de62f0b](https://togithub.com/googleapis/nodejs-cloud-container/commit/de62f0bfc4d6972d1bbd48428ec2005ef2ccf890)) ### Bug Fixes * **deps:** Use google-gax v3.5.2 ([#582](https://togithub.com/googleapis/nodejs-cloud-container/issues/582)) ([3c62c1a](https://togithub.com/googleapis/nodejs-cloud-container/commit/3c62c1adbc913212097f50496e10c4ccfb6f2d86)) * Update proto definitions ([#586](https://togithub.com/googleapis/nodejs-cloud-container/issues/586)) ([dbee22e](https://togithub.com/googleapis/nodejs-cloud-container/commit/dbee22e4f5e793d1e1ebe5cec33edf2128963a60)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com>
Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com>
Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com>
spreading the results allows the endpoint to pick up the individual params. Previous method does not work.
see https://developers.google.com/analytics/devguides/collection/protocol/v1/reference for more