-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added samples for App Engine Standard Environment #579
Conversation
Per our conversation just now - if there aren't too many changes between the Standard and Flex samples, we should change the Flex samples to support Standard as well. My thoughts: we can include the Standard-specific files in the same directory, e.g |
I would like to see a stand alone folder for Node.js standard only. A few concerns about a shared sample folder:
|
At the risk of overcomplicating things: one potential compromise (that I'm not entirely sold on yet) is to have a "master" set of files for both platforms (that isn't shown in the docs), and then use a ( |
Also - per the |
Yes, gcloud app deploy ANYFILENAMEHERE.yaml works. One issue here is that the video thats in the works mentions to simply run "gcloud app deploy". There are approximately 28 files in the flexible environment that use the _github_include and would take time to edit and test. Perhaps we maintain simplicity for standard and leave those files as app.yaml but for any flexible environment files, rename those to app.flexible.yaml? I realize that would leave it open to issues with Flex users just running 'gcloud app deploy' but the flexible docs would change all the copy/paste commands to "gcloud app deploy app.flexible.yaml", so it would ultimately be user error for not reading? |
How hard would it be to change the video? I'd rather have such user error end in a clear "halt and catch fire" case (such as |
For quickstarts, it should be a goal that developers don't have to rename files and can just type For other docs samples, I think it's OK to ask to use Now, do we do:
I have a preference for 1. |
Ultimately Im advocating for our users most optimal experience. Our Quickstart is suppose to be that hook, "all i do is run gcloud app deploy and it works". For this new language, we are changing the conventions we have been pushing since we started using gcloud app deploy, which might catch some users off guard. We also dont have a app.standard.yaml task topic nor reference topic, they all refer to "app.yaml". In our advanced tasks, we do introduce the concept of multiple services and uniquely named app.yaml files but thats not a new user concept and adds unwanted cognitive load for a new user. What are the trade offs? Editing the 28 flex files and revising the new standard files will take some time because of all the extra language around explaining why these files are named differently (not app.yaml). Regarding maintaining the node.js code samples, what has the overhead looked like over the last 2+ years since the flex docs went out? Im wondering what how much maintenance is required if there are two folders for Node.js (ie. what is the trade off for better UX vs. easier file handling)? |
🤖 I have created a release \*beep\* \*boop\* --- ## [3.22.0](https://www.github.com/googleapis/nodejs-asset/compare/v3.21.0...v3.22.0) (2021-11-12) ### Features * Update OSConfig API ([#578](https://www.github.com/googleapis/nodejs-asset/issues/578)) ([8af0ac8](https://www.github.com/googleapis/nodejs-asset/commit/8af0ac8a915b8b72d379b4e2a14c888ef98dfcf1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release \*beep\* \*boop\* --- ## [3.22.0](https://www.github.com/googleapis/nodejs-asset/compare/v3.21.0...v3.22.0) (2021-11-12) ### Features * Update OSConfig API ([#578](https://www.github.com/googleapis/nodejs-asset/issues/578)) ([8af0ac8](https://www.github.com/googleapis/nodejs-asset/commit/8af0ac8a915b8b72d379b4e2a14c888ef98dfcf1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release \*beep\* \*boop\* --- ### [3.3.6](https://www.github.com/googleapis/nodejs-video-intelligence/compare/v3.3.5...v3.3.6) (2021-07-21) ### Bug Fixes * **deps:** google-gax v2.17.1 ([#577](https://www.github.com/googleapis/nodejs-video-intelligence/issues/577)) ([53ba013](https://www.github.com/googleapis/nodejs-video-intelligence/commit/53ba01323adff17801b05c4d976368a691bc9f4b)) * Updating WORKSPACE files to use the newest version of the Typescript generator. ([#579](https://www.github.com/googleapis/nodejs-video-intelligence/issues/579)) ([46cfd26](https://www.github.com/googleapis/nodejs-video-intelligence/commit/46cfd265981b58b04dcc26960a9f0961c424cd92)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release \*beep\* \*boop\* --- ## [3.22.0](https://www.github.com/googleapis/nodejs-asset/compare/v3.21.0...v3.22.0) (2021-11-12) ### Features * Update OSConfig API ([#578](https://www.github.com/googleapis/nodejs-asset/issues/578)) ([8af0ac8](https://www.github.com/googleapis/nodejs-asset/commit/8af0ac8a915b8b72d379b4e2a14c888ef98dfcf1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release \*beep\* \*boop\* --- ## [3.22.0](https://www.github.com/googleapis/nodejs-asset/compare/v3.21.0...v3.22.0) (2021-11-12) ### Features * Update OSConfig API ([#578](https://www.github.com/googleapis/nodejs-asset/issues/578)) ([8af0ac8](https://www.github.com/googleapis/nodejs-asset/commit/8af0ac8a915b8b72d379b4e2a14c888ef98dfcf1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release \*beep\* \*boop\* --- ## [3.22.0](https://www.github.com/googleapis/nodejs-asset/compare/v3.21.0...v3.22.0) (2021-11-12) ### Features * Update OSConfig API ([#578](https://www.github.com/googleapis/nodejs-asset/issues/578)) ([8af0ac8](https://www.github.com/googleapis/nodejs-asset/commit/8af0ac8a915b8b72d379b4e2a14c888ef98dfcf1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [4.3.0](https://togithub.com/googleapis/nodejs-cloud-container/compare/v4.2.0...v4.3.0) (2022-10-14) ### Features * Launch GKE Cost Allocations configuration to the v1 GKE API ([#577](https://togithub.com/googleapis/nodejs-cloud-container/issues/577)) ([b45ac9f](https://togithub.com/googleapis/nodejs-cloud-container/commit/b45ac9fb6cff9a634ea62b2c9e6998c57bf837ef)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [4.3.0](https://togithub.com/googleapis/nodejs-cloud-container/compare/v4.2.0...v4.3.0) (2022-10-14) ### Features * Launch GKE Cost Allocations configuration to the v1 GKE API ([#577](https://togithub.com/googleapis/nodejs-cloud-container/issues/577)) ([b45ac9f](https://togithub.com/googleapis/nodejs-cloud-container/commit/b45ac9fb6cff9a634ea62b2c9e6998c57bf837ef)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [4.3.0](https://togithub.com/googleapis/nodejs-cloud-container/compare/v4.2.0...v4.3.0) (2022-10-14) ### Features * Launch GKE Cost Allocations configuration to the v1 GKE API ([#577](https://togithub.com/googleapis/nodejs-cloud-container/issues/577)) ([b45ac9f](https://togithub.com/googleapis/nodejs-cloud-container/commit/b45ac9fb6cff9a634ea62b2c9e6998c57bf837ef)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
🤖 I have created a release \*beep\* \*boop\* --- ### [3.3.6](https://www.github.com/googleapis/nodejs-video-intelligence/compare/v3.3.5...v3.3.6) (2021-07-21) ### Bug Fixes * **deps:** google-gax v2.17.1 ([#577](https://www.github.com/googleapis/nodejs-video-intelligence/issues/577)) ([53ba013](https://www.github.com/googleapis/nodejs-video-intelligence/commit/53ba01323adff17801b05c4d976368a691bc9f4b)) * Updating WORKSPACE files to use the newest version of the Typescript generator. ([#579](https://www.github.com/googleapis/nodejs-video-intelligence/issues/579)) ([46cfd26](https://www.github.com/googleapis/nodejs-video-intelligence/commit/46cfd265981b58b04dcc26960a9f0961c424cd92)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [4.3.0](https://togithub.com/googleapis/nodejs-cloud-container/compare/v4.2.0...v4.3.0) (2022-10-14) ### Features * Launch GKE Cost Allocations configuration to the v1 GKE API ([#577](https://togithub.com/googleapis/nodejs-cloud-container/issues/577)) ([b45ac9f](https://togithub.com/googleapis/nodejs-cloud-container/commit/b45ac9fb6cff9a634ea62b2c9e6998c57bf837ef)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [4.3.0](https://togithub.com/googleapis/nodejs-cloud-container/compare/v4.2.0...v4.3.0) (2022-10-14) ### Features * Launch GKE Cost Allocations configuration to the v1 GKE API ([#577](https://togithub.com/googleapis/nodejs-cloud-container/issues/577)) ([b45ac9f](https://togithub.com/googleapis/nodejs-cloud-container/commit/b45ac9fb6cff9a634ea62b2c9e6998c57bf837ef)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
🤖 I have created a release \*beep\* \*boop\* --- ## [3.22.0](https://www.github.com/googleapis/nodejs-asset/compare/v3.21.0...v3.22.0) (2021-11-12) ### Features * Update OSConfig API ([#578](https://www.github.com/googleapis/nodejs-asset/issues/578)) ([8af0ac8](https://www.github.com/googleapis/nodejs-asset/commit/8af0ac8a915b8b72d379b4e2a14c888ef98dfcf1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release \*beep\* \*boop\* --- ### [3.3.6](https://www.github.com/googleapis/nodejs-video-intelligence/compare/v3.3.5...v3.3.6) (2021-07-21) ### Bug Fixes * **deps:** google-gax v2.17.1 ([#577](https://www.github.com/googleapis/nodejs-video-intelligence/issues/577)) ([53ba013](https://www.github.com/googleapis/nodejs-video-intelligence/commit/53ba01323adff17801b05c4d976368a691bc9f4b)) * Updating WORKSPACE files to use the newest version of the Typescript generator. ([#579](https://www.github.com/googleapis/nodejs-video-intelligence/issues/579)) ([46cfd26](https://www.github.com/googleapis/nodejs-video-intelligence/commit/46cfd265981b58b04dcc26960a9f0961c424cd92)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [4.3.0](https://togithub.com/googleapis/nodejs-cloud-container/compare/v4.2.0...v4.3.0) (2022-10-14) ### Features * Launch GKE Cost Allocations configuration to the v1 GKE API ([#577](https://togithub.com/googleapis/nodejs-cloud-container/issues/577)) ([b45ac9f](https://togithub.com/googleapis/nodejs-cloud-container/commit/b45ac9fb6cff9a634ea62b2c9e6998c57bf837ef)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
No description provided.