Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KMS: Makes samples consistent across languages. by @white0ut #461

Merged
merged 1 commit into from
Aug 23, 2017
Merged

KMS: Makes samples consistent across languages. by @white0ut #461

merged 1 commit into from
Aug 23, 2017

Commits on Aug 23, 2017

  1. KMS: Makes samples consistent across languages. 

    This change, in particular:

* Consistently names variables with the API (locationId, keyRingId,
  cryptoKeyId).
* Displays the function name in the region tag.
* Correctly writes decoded base64 to disk  and encodes file contents
  before calling KMS.
* Correctly loads decoded base64 from disk.
* Labels parameters as plaintextFileName and ciphertextFileName, rather
  than inFile and outFile where applicable.
* Makes test failure messages more readable.
    @white0ut @jmdobry
    white0ut authored and jmdobry committed Aug 23, 2017
    Configuration menu
    Copy the full SHA
    1857294 View commit details
    Browse the repository at this point in the history