-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add postgres samples #396
Add postgres samples #396
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,7 +24,9 @@ | |
}, | ||
"dependencies": { | ||
"express": "4.15.2", | ||
"knex": "^0.13.0", | ||
"mysql": "2.13.0", | ||
"pg": "^6.2.3", | ||
"prompt": "1.0.0" | ||
}, | ||
"devDependencies": { | ||
|
@@ -35,19 +37,18 @@ | |
"test": { | ||
"app": { | ||
"requiredEnvVars": [ | ||
"MYSQL_USER", | ||
"MYSQL_PASSWORD", | ||
"MYSQL_DATABASE", | ||
"YOUR_INSTANCE_CONNECTION_NAME" | ||
"SQL_CLIENT", | ||
"SQL_USER", | ||
"SQL_PASSWORD", | ||
"SQL_DATABASE", | ||
"INSTANCE_CONNECTION_NAME" | ||
], | ||
"msg": "Last 10 visits:", | ||
"args": ["server.js"] | ||
}, | ||
"deploy": { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why remove this configuration? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The line below it seems to be MySQL-specific environment variables - but if we use the same environment variables for both clients, then I'll add it back in + update it accordingly. |
||
"substitutions": "YOUR_USER=$MYSQL_USER,YOUR_PASSWORD=$MYSQL_PASSWORD,YOUR_DATABASE=$MYSQL_DATABASE,YOUR_INSTANCE_CONNECTION_NAME=$INSTANCE_CONNECTION_NAME" | ||
"substitutions": "YOUR_SQL_CLIENT=$SQL_CLIENT,YOUR_USER=$SQL_USER,YOUR_PASSWORD=$SQL_PASSWORD,YOUR_DATABASE=$SQL_DATABASE,YOUR_INSTANCE_CONNECTION_NAME=$INSTANCE_CONNECTION_NAME", | ||
"args": [ | ||
"server.js" | ||
] | ||
} | ||
}, | ||
"requiresKeyFile": true, | ||
"requiresProjectId": true | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a dependency on
pg
. Runyarn add pg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing also a dependency on
knex