Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add storage control folder and managed folder samples #3761

Merged
merged 5 commits into from
Jul 26, 2024
Merged

feat: add storage control folder and managed folder samples #3761

merged 5 commits into from
Jul 26, 2024

Conversation

ddelgrosso1
Copy link
Contributor

@ddelgrosso1 ddelgrosso1 commented Jul 25, 2024 •
edited
Loading

Description

Fixes #3713

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@ddelgrosso1 ddelgrosso1 requested review from a team as code owners July 25, 2024 20:24
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Jul 25, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 10 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: workflows Issues related to the Workflows API. labels Jul 25, 2024
tritone
tritone approved these changes Jul 26, 2024
View reviewed changes
storage-control/createFolder.js
// const bucketName = 'bucketName';

// The name of the folder to be created
// const folderName = 'folderName';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: here and elsewhere, folder & managed folder names can be local variables since they can be static during testing. See https://googlecloudplatform.github.io/samples-style-guide/#minimal-arguments

@ddelgrosso1 ddelgrosso1 merged commit e755f7d into main Jul 26, 2024
32 checks passed
@ddelgrosso1 ddelgrosso1 deleted the storage-control-samples branch July 26, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritone tritone tritone approved these changes

@danielbankhead danielbankhead danielbankhead approved these changes

@sydney-munro sydney-munro sydney-munro approved these changes

Assignees

@pattishin pattishin

@sydney-munro sydney-munro

Labels
api: workflows Issues related to the Workflows API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

storage-control: Samples for Managed Folders
5 participants
@ddelgrosso1 @tritone @danielbankhead @sydney-munro @pattishin