Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update m-r workflows to use labeled on pull_request trigger #3751

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

grayside
Copy link
Collaborator

@grayside grayside commented Jul 19, 2024

Description

Scoped to Samples workflows with file names starting with m, n, o, p, q, r.

Implementation of #3747, sibling of #3748.

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: workflows Issues related to the Workflows API. labels Jul 19, 2024
@grayside grayside added actions:force-run and removed api: workflows Issues related to the Workflows API. labels Jul 19, 2024
@grayside
Copy link
Collaborator Author

grayside commented Jul 19, 2024

retail tests seem to be failing on finding a required GCS bucket already exists. This might be because of the concurrent tests in this PR.

monitoring tests are complaining about too many changes to project configuration, which sounds like it may also be a concurrency problem, and one that may not be solvable using a single project.

Both these sets of tests corrected after retrying, I left the pull_request_target version exposed for easier inspection of the problem. Fixing these is out of scope for the PR, but supporting concurrent testing is something that should be followed-up.

@grayside grayside marked this pull request as ready for review July 19, 2024 22:53
@grayside grayside requested review from a team as code owners July 19, 2024 22:53
Copy link
Contributor

@iennae iennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I appreciate that you've got the assessment of the issues documented as well.

@grayside grayside enabled auto-merge (squash) July 22, 2024 17:18
@grayside grayside merged commit 6de13a9 into main Jul 22, 2024
28 of 48 checks passed
@grayside grayside deleted the prt-mr-tests branch July 22, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions:force-run samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants