Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update node version #3735

Merged
merged 1 commit into from
Jul 10, 2024
Merged

chore: update node version #3735

merged 1 commit into from
Jul 10, 2024

Conversation

subfuzion
Copy link
Member

@subfuzion subfuzion commented Jul 9, 2024 •
edited
Loading

Description

Bump engines.node to v18. This is the current active Node.js version and allows fetch to be used (provides a web standard alternative to using third party request libraries).

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@subfuzion subfuzion requested a review from a team as a code owner July 9, 2024 23:41
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jul 9, 2024
iennae
iennae approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@iennae iennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on Cloud SDK supported versioning and that based on runtime constraints while we aren't decommissioning nodejs10-16 until 2025-01-30, I think we can do this change.

The image is available now based on this PR https://github.com/googleapis/testing-infra-docker/pull/387/files so we can update to 18.

@iennae iennae added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 10, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 10, 2024
@subfuzion subfuzion merged commit f148440 into GoogleCloudPlatform:main Jul 10, 2024
27 checks passed
@subfuzion subfuzion deleted the chore/update-node-version branch July 10, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iennae iennae iennae approved these changes

Assignees
No one assigned
Labels
samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@subfuzion @iennae