Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update the sentiment threshold; fix a typo in some commented-out code. #341

Merged
merged 3 commits into from
Apr 12, 2017
Merged

update the sentiment threshold; fix a typo in some commented-out code. #341

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e3a2ad
update the sentiment threshold; fix a typo in some commented-out code.
amygdala Apr 6, 2017
97a79dc
Fix lint error
Apr 11, 2017
9c0ee2d
Merge branch 'master' into sfix
Apr 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions language/slackbot/demo_bot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,10 @@ const db = new sqlite3.cached.Database(path.join(__dirname, './slackDB.db'));

// the number of most frequent entities to retrieve from the db on request.
const NUM_ENTITIES = 20;
// The magnitude of sentiment of a posted text above which the bot will respond.
const SENTIMENT_THRESHOLD = 30;
// The threshold of sentiment score of a posted text, above which the bot will
// respond. This threshold is rather arbitrary; you may want to play with this
// value.
const SENTIMENT_THRESHOLD = 0.3;
const SEVEN_DAYS_AGO = 60 * 60 * 24 * 7;

const ENTITIES_BASE_SQL = `SELECT name, type, count(name) as wc
Expand Down Expand Up @@ -218,10 +220,11 @@ function analyzeSentiment (text) {
.then((results) => {
const sentiment = results[0];

// Uncomment the following four lines to log the sentiment to the console:
// if (results >= SENTIMENT_THRESHOLD) {
// Uncomment the following lines to log the sentiment to the console:
// console.log(`Sentiment: ${sentiment}`)
// if (sentiment >= SENTIMENT_THRESHOLD) {
// console.log('Sentiment: positive.');
// } else if (results <= -SENTIMENT_THRESHOLD) {
// } else if (sentiment <= -SENTIMENT_THRESHOLD) {
// console.log('Sentiment: negative.');
// }

Expand All @@ -237,10 +240,11 @@ function handleAmbientMessage (bot, message) {
.then(() => analyzeSentiment(message.text))
.then((sentiment) => {
if (sentiment >= SENTIMENT_THRESHOLD) {
// We have a positive sentiment of magnitude larger than the threshold.
// We have a positive sentiment score larger than the threshold.
bot.reply(message, ':thumbsup:');
} else if (sentiment <= -SENTIMENT_THRESHOLD) {
// We have a negative sentiment of magnitude larger than the threshold.
// We have a negative sentiment score of absolute value larger than
// the threshold.
bot.reply(message, ':thumbsdown:');
}
});
Expand Down