Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: shifting test http region tags to show imports #3405

Merged
merged 9 commits into from
Aug 15, 2023
Merged

chore: shifting test http region tags to show imports #3405

Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
05b0e22
refactor: shifting region tags to show imports tps could miss
pattishin Aug 8, 2023
3df772e
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Aug 8, 2023
0aa71f1
Merge branch 'main' into refactor/b-293920805
pattishin Aug 8, 2023
125e3d8
Merge branch 'main' into refactor/b-293920805
pattishin Aug 9, 2023
a7e67f2
refactor: wrapping getFunction import under functions_http_unit_test …
pattishin Aug 9, 2023
4e00484
Merge branch 'main' into refactor/b-293920805
pattishin Aug 11, 2023
b945029
Merge branch 'main' into refactor/b-293920805
pattishin Aug 14, 2023
2e71607
Merge branch 'main' into refactor/b-293920805
pattishin Aug 15, 2023
14e51b8
Merge branch 'main' into refactor/b-293920805
pattishin Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions functions/helloworld/helloworldHttp/test/sample.unit.http.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@
// limitations under the License.

// FF testing layer for declarative signatures
// [START functions_http_unit_test]
pattishin marked this conversation as resolved.
Show resolved Hide resolved
const {getFunction} = require('@google-cloud/functions-framework/testing');

describe('functions_helloworld_http', () => {
// [START functions_http_unit_test]
const sinon = require('sinon');
const assert = require('assert');
require('../');
Expand All @@ -40,7 +40,7 @@ describe('functions_helloworld_http', () => {

assert.strictEqual(mocks.res.send.calledOnceWith('Hello World!'), true);
});
// [END functions_http_unit_test]

it('helloHttp: should print a name with query', () => {
const mocks = getMocks();
mocks.req.query = {name: 'John'};
Expand All @@ -61,3 +61,4 @@ describe('functions_helloworld_http', () => {
assert.strictEqual(mocks.res.send.calledOnceWith('Hello John!'), true);
});
});
// [END functions_http_unit_test]
Loading