Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: node 16 upgrade 🚧 [WIP] #3309

Closed
wants to merge 20 commits into from
Closed

Conversation

pattishin
Copy link
Contributor

@pattishin pattishin commented Jun 29, 2023

Description

Issue: Test PR to run tests / enumerate effort to upgrade our product folders to minimum node 16 (later to latest node 18)
Relates to #3328 and googleapis/testing-infra-docker#287.

(https://endoflife.date/nodejs)

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@pattishin pattishin added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 29, 2023
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jun 29, 2023
@pattishin pattishin changed the title [WIP] chore: node 16 upgrade 🚧 chore: node 16 upgrade 🚧 [WIP] Jul 5, 2023
@pattishin pattishin removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 5, 2023
@pattishin
Copy link
Contributor Author

Opting to upgrade node 18 directly. Closing out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants