-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: node 16 upgrade 🚧 [WIP] #3309
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pattishin
added
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Jun 29, 2023
product-auto-label
bot
added
the
samples
Issues that are directly related to samples.
label
Jun 29, 2023
pattishin
changed the title
[WIP] chore: node 16 upgrade 🚧
chore: node 16 upgrade 🚧 [WIP]
Jul 5, 2023
pattishin
force-pushed
the
chore/node-16-upgrade
branch
from
July 5, 2023 21:07
861277e
to
280fbca
Compare
pattishin
removed
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Jul 5, 2023
…or on promise failure
Opting to upgrade node 18 directly. Closing out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue: Test PR to run tests / enumerate effort to upgrade our product folders to minimum node 16 (later to latest node 18)
Relates to #3328 and googleapis/testing-infra-docker#287.
(https://endoflife.date/nodejs)
Checklist
npm test
(see Testing)npm run lint
(see Style)