-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spanner samples #313
Spanner samples #313
Conversation
.gitignore
Outdated
@@ -1,3 +1,6 @@ | |||
.DS_Store |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This goes in your global gitignore, not in the repositories.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to sync package.json
files via scrpts/unify
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but only because the test script isn't smart enough to recognize new tests. The spanner tests won't actually run until this is merged.
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
🤖 I have created a release \*beep\* \*boop\* --- ### [2.1.2](https://www.github.com/googleapis/nodejs-scheduler/compare/v2.1.1...v2.1.2) (2020-11-25) ### Bug Fixes * **browser:** check for fetch on window ([#313](https://www.github.com/googleapis/nodejs-scheduler/issues/313)) ([5a7840a](https://www.github.com/googleapis/nodejs-scheduler/commit/5a7840acbe5cbd96be701c8d06a3ec350bf45cc1)) * do not modify options object, use defaultScopes ([#305](https://www.github.com/googleapis/nodejs-scheduler/issues/305)) ([7f8b30c](https://www.github.com/googleapis/nodejs-scheduler/commit/7f8b30c165d3de8beebb0e6704535b4eed7d817d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
🤖 I have created a release \*beep\* \*boop\* --- ### [2.1.2](https://www.github.com/googleapis/nodejs-scheduler/compare/v2.1.1...v2.1.2) (2020-11-25) ### Bug Fixes * **browser:** check for fetch on window ([#313](https://www.github.com/googleapis/nodejs-scheduler/issues/313)) ([5a7840a](https://www.github.com/googleapis/nodejs-scheduler/commit/5a7840acbe5cbd96be701c8d06a3ec350bf45cc1)) * do not modify options object, use defaultScopes ([#305](https://www.github.com/googleapis/nodejs-scheduler/issues/305)) ([7f8b30c](https://www.github.com/googleapis/nodejs-scheduler/commit/7f8b30c165d3de8beebb0e6704535b4eed7d817d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
🤖 I have created a release \*beep\* \*boop\* --- ### [2.1.2](https://www.github.com/googleapis/nodejs-scheduler/compare/v2.1.1...v2.1.2) (2020-11-25) ### Bug Fixes * **browser:** check for fetch on window ([#313](https://www.github.com/googleapis/nodejs-scheduler/issues/313)) ([5a7840a](https://www.github.com/googleapis/nodejs-scheduler/commit/5a7840acbe5cbd96be701c8d06a3ec350bf45cc1)) * do not modify options object, use defaultScopes ([#305](https://www.github.com/googleapis/nodejs-scheduler/issues/305)) ([7f8b30c](https://www.github.com/googleapis/nodejs-scheduler/commit/7f8b30c165d3de8beebb0e6704535b4eed7d817d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
🤖 I have created a release \*beep\* \*boop\* --- ### [2.1.2](https://www.github.com/googleapis/nodejs-scheduler/compare/v2.1.1...v2.1.2) (2020-11-25) ### Bug Fixes * **browser:** check for fetch on window ([#313](https://www.github.com/googleapis/nodejs-scheduler/issues/313)) ([5a7840a](https://www.github.com/googleapis/nodejs-scheduler/commit/5a7840acbe5cbd96be701c8d06a3ec350bf45cc1)) * do not modify options object, use defaultScopes ([#305](https://www.github.com/googleapis/nodejs-scheduler/issues/305)) ([7f8b30c](https://www.github.com/googleapis/nodejs-scheduler/commit/7f8b30c165d3de8beebb0e6704535b4eed7d817d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
* added create-featurestore-sample.js and create-featurestore-sample.test.js * feat(samples): added createFeaturestore sample (#313) * feat(samples): added remaining featurestore samples (#313) * removed the extraneous files * feat(samples): added create-featurestore sample (#313) * feat(samples): added variation of create-featurestore sample (#313) * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* added create-featurestore-sample.js and create-featurestore-sample.test.js * feat(samples): added createFeaturestore sample (#313) * feat(samples): added remaining featurestore samples (#313) * removed the extraneous files * feat(samples): add remaining featurestore api samples (#313) * feat(samples): add remaining featurestore apis samples (#313) * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat(samples): changed timeout of featurestore apis samples (#313) * feat(samples): update featurestore-samples.test.js (#313) Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: junkourata <102059808+junkourata@users.noreply.github.com>
* added create-featurestore-sample.js and create-featurestore-sample.test.js * feat(samples): added createFeaturestore sample (#313) * feat(samples): added remaining featurestore samples (#313) * removed the extraneous files * feat(samples): add entity type apis samples (#313) * feat(samples): changed timeout for entity type apis samples (#313) * feat(samples): update entity-type-samples.test.js (#313) * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: junkourata <102059808+junkourata@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* added create-featurestore-sample.js and create-featurestore-sample.test.js * feat(samples): added createFeaturestore sample (#313) * feat(samples): added remaining featurestore samples (#313) * removed the extraneous files * feat(samples): add feature apis samples (#313) * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat(samples): updated feature-samples.test.js (#313) * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: junkourata <102059808+junkourata@users.noreply.github.com>
* added create-featurestore-sample.js and create-featurestore-sample.test.js * feat(samples): added createFeaturestore sample (#313) * feat(samples): added remaining featurestore samples (#313) * removed the extraneous files * feat(samples): add feature-values apis samples (#313) * feat(samples): add feature values apis samples (#313) * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat(samples): update dependency featurevalues apis (#313) * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: junkourata <102059808+junkourata@users.noreply.github.com>
* added create-featurestore-sample.js and create-featurestore-sample.test.js * feat(samples): added createFeaturestore sample (#313) * feat(samples): added remaining featurestore samples (#313) * removed the extraneous files * feat(samples): added create-featurestore sample (#313) * feat(samples): added variation of create-featurestore sample (#313) * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* added create-featurestore-sample.js and create-featurestore-sample.test.js * feat(samples): added createFeaturestore sample (#313) * feat(samples): added remaining featurestore samples (#313) * removed the extraneous files * feat(samples): add remaining featurestore api samples (#313) * feat(samples): add remaining featurestore apis samples (#313) * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat(samples): changed timeout of featurestore apis samples (#313) * feat(samples): update featurestore-samples.test.js (#313) Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: junkourata <102059808+junkourata@users.noreply.github.com>
* added create-featurestore-sample.js and create-featurestore-sample.test.js * feat(samples): added createFeaturestore sample (#313) * feat(samples): added remaining featurestore samples (#313) * removed the extraneous files * feat(samples): add entity type apis samples (#313) * feat(samples): changed timeout for entity type apis samples (#313) * feat(samples): update entity-type-samples.test.js (#313) * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: junkourata <102059808+junkourata@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* added create-featurestore-sample.js and create-featurestore-sample.test.js * feat(samples): added createFeaturestore sample (#313) * feat(samples): added remaining featurestore samples (#313) * removed the extraneous files * feat(samples): add feature apis samples (#313) * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat(samples): updated feature-samples.test.js (#313) * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: junkourata <102059808+junkourata@users.noreply.github.com>
* added create-featurestore-sample.js and create-featurestore-sample.test.js * feat(samples): added createFeaturestore sample (#313) * feat(samples): added remaining featurestore samples (#313) * removed the extraneous files * feat(samples): add feature-values apis samples (#313) * feat(samples): add feature values apis samples (#313) * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat(samples): update dependency featurevalues apis (#313) * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: junkourata <102059808+junkourata@users.noreply.github.com>
(FYI these were already reviewed by @jmdobry. @jonparrott, these should be good to merge - but feel free to skim them + verify.)