Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: adding DEEPO to CODEOWNERS for monitoring/ #2845

Closed
wants to merge 3 commits into from

Conversation

ahrarmonsur
Copy link
Contributor

@ahrarmonsur ahrarmonsur commented Nov 14, 2022

I updated the reviewer groups for monitoring based on this ownership sheet:
go/dee-monorepo-migration-tracker

In response to:
#2807 (review)

@ahrarmonsur ahrarmonsur requested a review from a team as a code owner November 14, 2022 14:32
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 14, 2022
@google-cla
Copy link

google-cla bot commented Nov 14, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@bcoe bcoe changed the title Adding DEEPO to CODEOWNERS for monitoring/ build: adding DEEPO to CODEOWNERS for monitoring/ Nov 14, 2022
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we already landed this commit history with the last PR, I would squash this commit:

git reset --soft HEAD~149
git commit -m 'build: adding DEEPO to CODWOWNERS for monitoring/

@ahrarmonsur ahrarmonsur requested review from a team as code owners November 14, 2022 16:26
@ahrarmonsur ahrarmonsur requested a review from a team November 14, 2022 16:26
@ahrarmonsur ahrarmonsur requested a review from a team as a code owner November 14, 2022 16:26
@ahrarmonsur ahrarmonsur requested review from bcoe and removed request for a team November 14, 2022 16:32
@NimJay
Copy link
Contributor

NimJay commented Nov 16, 2022

As discussed in our sync, Ace fixed the unrelated failing CI test in #2847 (review).
All checks should now pass. 🤞

@ahrarmonsur
Copy link
Contributor Author

Closing this PR in favor of having @NimJay do a mega-PR with all CODEOWNER changes at once, following the Fixit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants