fix(functions): Fix/update GCF Memorystore sample #2780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
api: cloudfunctions
averikitsch
approved these changes
Nov 16, 2022
averikitsch
requested changes
Nov 16, 2022
There was a problem hiding this comment.
This needs a workflow file to run the tests. See https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/.github/workflows/functions-slack.yaml for an example
|
@averikitsch Thanks, done! |
|
Forks don't get access to secrets. I ran the test under my credentials https://github.com/GoogleCloudPlatform/nodejs-docs-samples/actions/runs/3491368815/jobs/5843921346. |
averikitsch
approved these changes
Nov 17, 2022
ace-n
approved these changes
Nov 17, 2022
|
Test passed on @akitsch's run; merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Node.js Redis client's interface changed in v4 to use Promises by default, so this update addresses that.
This PR also: