Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(functions): Fix/update GCF Memorystore sample #2780

Merged
merged 4 commits into from
Nov 17, 2022
Merged

fix(functions): Fix/update GCF Memorystore sample #2780

merged 4 commits into from
Nov 17, 2022

Conversation

ericschmidtatwork
Copy link
Contributor

The Node.js Redis client's interface changed in v4 to use Promises by default, so this update addresses that.

This PR also:

  • Updates the function definition to use the declarative Functions Framework syntax
  • Makes corresponding updates to the unit test
  • Adds a link in the README to the tutorial that uses this sample

@ericschmidtatwork ericschmidtatwork requested a review from a team as a code owner October 13, 2022 23:15
@product-auto-label product-auto-label bot added api: cloudfunctions Issues related to the Cloud Run functions API. samples Issues that are directly related to samples. labels Oct 13, 2022
Copy link
Contributor

@averikitsch averikitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericschmidtatwork ericschmidtatwork requested a review from a team as a code owner November 17, 2022 00:19
@ericschmidtatwork
Copy link
Contributor Author

@averikitsch Thanks, done!

@averikitsch
Copy link
Contributor

Forks don't get access to secrets. I ran the test under my credentials https://github.com/GoogleCloudPlatform/nodejs-docs-samples/actions/runs/3491368815/jobs/5843921346.

@ace-n
Copy link
Contributor

ace-n commented Nov 17, 2022

Test passed on @akitsch's run; merging.

@ace-n ace-n merged commit 7590080 into GoogleCloudPlatform:main Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudfunctions Issues related to the Cloud Run functions API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants