-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(build): migrate to using main branch #2314
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -19,7 +19,7 @@ | |||
# | |||
|
|||
# The configuration schema is defined by service.proto file | |||
# https://github.com/googleapis/googleapis/blob/master/google/api/service.proto | |||
# https://github.com/googleapis/googleapis/blob/main/google/api/service.proto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
N.B: this is talking about a repo other than nodejs-docs-samples
, and currently 404
s.
Maybe we should do one of the following? Feel free to use whichever one you'd prefer.
a) manually check that all these links work
b) not change anything outside of nodejs-docs-samples
for now, and file a follow-up issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ace! I fixed the offending links :)
Looks like the failing docs test is very real here :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@sofisl you might need to push an empty commit to kick off tests, I'm betting you got bit by actions being down earlier this week. |
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
No description provided.