Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): migrate to using main branch #2314

Merged
merged 6 commits into from
Aug 17, 2021
Merged

Conversation

sofisl
Copy link
Collaborator

@sofisl sofisl commented Aug 12, 2021

No description provided.

@sofisl sofisl requested review from ace-n, engelke and a team as code owners August 12, 2021 18:02
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 12, 2021
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 12, 2021
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -19,7 +19,7 @@
#

# The configuration schema is defined by service.proto file
# https://github.com/googleapis/googleapis/blob/master/google/api/service.proto
# https://github.com/googleapis/googleapis/blob/main/google/api/service.proto
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

N.B: this is talking about a repo other than nodejs-docs-samples, and currently 404s.

Maybe we should do one of the following? Feel free to use whichever one you'd prefer.
a) manually check that all these links work
b) not change anything outside of nodejs-docs-samples for now, and file a follow-up issue

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ace! I fixed the offending links :)

@JustinBeckwith
Copy link
Contributor

Looks like the failing docs test is very real here :)

@sofisl sofisl requested a review from ace-n August 13, 2021 19:22
Copy link
Contributor

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcoe
Copy link
Contributor

bcoe commented Aug 13, 2021

@sofisl you might need to push an empty commit to kick off tests, I'm betting you got bit by actions being down earlier this week.

@sofisl sofisl added the automerge Merge the pull request once unit tests and other checks pass. label Aug 13, 2021
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants