-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deployment tests. Closes #21. #23
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
**/node_modules/** | ||
npm-debug.log | ||
coverage/ | ||
coverage/ | ||
|
||
test/encrypted/nodejs-docs-samples.json |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,43 +1,13 @@ | ||
## Express on Google App Engine | ||
## Express.js on Google App Engine | ||
|
||
> [Express](http://expressjs.com) is a minimal and flexible Node.js web | ||
application framework that provides a robust set of features for web and mobile | ||
applications. | ||
> [Express][1] is a minimal and flexible Node.js web application framework that | ||
provides a robust set of features for web and mobile applications. | ||
|
||
You can view the deployed demo app [here](https://express-demo.appspot.com). | ||
Read the [Express.js on App Engine Tutorial][2] for how to run and deploy this | ||
sample app. | ||
|
||
### Create a new Express app | ||
You can also view the [live demo][3] and read the [Express.js documentation][1]. | ||
|
||
View the [Express app generator guide](http://expressjs.com/starter/generator.html). | ||
|
||
### Configure | ||
|
||
Create an `app.yaml` in the root of your application with the following | ||
contents: | ||
|
||
```yaml | ||
runtime: nodejs | ||
vm: true | ||
api_version: 1 | ||
env_variables: | ||
PORT: 8080 | ||
``` | ||
|
||
### Deploy | ||
|
||
For convenience, you can use an npm script to run the `gcloud` command. Add | ||
these lines to your `package.json` file: | ||
|
||
```json | ||
"scripts": { | ||
"start": "node ./bin/www", | ||
"deploy": "gcloud preview app deploy app.yaml --promote --project <your-project-id>" | ||
} | ||
``` | ||
|
||
At the terminal you can now run the following command to deploy your | ||
application: | ||
|
||
``` | ||
$ npm deploy | ||
``` | ||
[1]: http://expressjs.com/ | ||
[2]: https://cloud.google.com/nodejs/resources/frameworks/express | ||
[3]: http://express-dot-nodejs-docs-samples.appspot.com |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,7 +14,6 @@ | |
# [START app_yaml] | ||
runtime: nodejs | ||
vm: true | ||
api_version: 1 | ||
env_variables: | ||
PORT: 8080 | ||
# [END app_yaml] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason we're still testing with 0.10?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was there, I left it? Does anyone know of a way to lookup the current usage stats of the different Node versions? Might be interesting to see the current rate of download for the different versions from the Node.js website.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if there's any public stats, but I doubt many are using 0.10 on GAE. @JustinBeckwith what do you think?