Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix system test #1893

Merged
merged 113 commits into from
Jun 19, 2020
Merged
Changes from all commits
Commits
Show all changes
113 commits
Select commit Hold shift + click to select a range
9d64ae1
Add service-to-service Node.js sample
Apr 3, 2020
64ab35f
Add service-to-service Node.js sample
kelsk Apr 3, 2020
00451bf
Update run/authentication/auth.js
kelsk Apr 3, 2020
86b0635
Update sample to address suggested changes
kelsk Apr 3, 2020
5132e26
Merge branch 'master' into auth
kelsk Apr 3, 2020
a176376
Merge pull request #1 from kelsk/auth
kelsk Apr 3, 2020
70ce8f7
Merge branch 'master' into master
kelsk Apr 3, 2020
5975b57
Initial code added
kelsk Apr 6, 2020
8e9ef37
Updated package.json; resolved issues in auth.js from review
kelsk Apr 13, 2020
867eb65
Removed auth from branch
kelsk Apr 13, 2020
62fd173
Markdown renderer & editor added
kelsk Apr 20, 2020
02dccb6
Markdown renderer & editor working
kelsk Apr 21, 2020
9ef850f
Added xss sanitizer
kelsk Apr 21, 2020
a56dca4
General cleanup
kelsk Apr 21, 2020
0bafa82
Delete .gitignore
kelsk Apr 21, 2020
bb14175
Delete .gitignore
kelsk Apr 21, 2020
1905b18
Removed errant console.log
kelsk Apr 21, 2020
8353e52
Update markdown converter, general code cleanup
kelsk Apr 23, 2020
039663d
updated README
kelsk Apr 24, 2020
39dfd1f
tests: added unit tests for editor & renderer
kelsk Apr 24, 2020
5985740
added timeout
kelsk Apr 24, 2020
0d0e2ef
tests: added editor & editor/render tests
kelsk Apr 27, 2020
7f32b81
tests: added & modified test in package.json
kelsk Apr 27, 2020
f43a2af
README: added env var
kelsk Apr 27, 2020
2db15ae
Revert "README: added env var"
kelsk Apr 27, 2020
7706dd1
README: added env var
kelsk Apr 27, 2020
0cdf727
updated author email
kelsk Apr 28, 2020
1d17988
Update run/markdown-preview/README.md
kelsk Apr 28, 2020
5fb25b1
add license to Dockerfile
kelsk Apr 29, 2020
43bb924
fixed json parsing error
kelsk Apr 29, 2020
bea221b
remove dependencies from root package.json
kelsk Apr 29, 2020
5277daf
remove xss (not needed)
kelsk Apr 30, 2020
a359786
update node version in Dockerfile
kelsk Apr 30, 2020
4391a1b
refactored code to reflect code review
kelsk Apr 30, 2020
d2410d8
updated tests to respond to new code
kelsk Apr 30, 2020
f2fe58e
update packages.json
kelsk Apr 30, 2020
54649d6
update README: Merge branch 'markdown' of https://github.com/kelsk/no…
kelsk Apr 30, 2020
88dd67d
run/markdown-preview: add sample
kelsk Apr 30, 2020
d70d1a6
update: syntax & grammar fixes
kelsk Apr 30, 2020
a8952fa
change: throw error if markdown data absent from req
kelsk Apr 30, 2020
f2706f0
change req.body validation
kelsk May 1, 2020
bca1bb3
fix syntax error
kelsk May 1, 2020
4890729
change: fixed file name
kelsk May 2, 2020
5de6e9c
syntax: remove newline
kelsk May 5, 2020
c97f02b
update: engine version
kelsk May 5, 2020
6c0897c
syntax: general fixes
kelsk May 5, 2020
8842611
code: replace json with plain text
kelsk May 6, 2020
b81c140
test: modified tests for accuracy
kelsk May 6, 2020
5a1d84e
syntax: minor fixes
kelsk May 6, 2020
971bff9
test: modified for new code
kelsk May 6, 2020
3c4ed75
added comment about xss
kelsk May 6, 2020
f4d8a99
code: unwrapped body.data
kelsk May 7, 2020
330206e
test: updated tests per code review
kelsk May 7, 2020
9f23945
code: added timeout to got request
kelsk May 8, 2020
8a0aa37
test: updated with sinon & error message reading
kelsk May 8, 2020
6bdf2b6
test: updated with sinon to read console log
kelsk May 8, 2020
42c6eb8
reformatted markdown declaration
kelsk May 8, 2020
675b19f
test: refactor to make valid tests
kelsk May 8, 2020
3503649
Updated sample to use google-auth-library
kelsk May 19, 2020
0bbd133
updated req.body conditional & markdown-it comment
kelsk May 19, 2020
d5fff16
Removed init(); added Renderer url to /render
kelsk May 19, 2020
5a7a2ec
Updated renderRequest client
kelsk May 19, 2020
f369ccc
Updated get to be async
kelsk May 19, 2020
394dc63
Updated tests to reflect new code
kelsk May 19, 2020
618b88e
Removed erroneous comment & outdated env var
kelsk May 19, 2020
a7bfaae
Removed unused js package
kelsk May 19, 2020
2b2844c
Added check for service url
kelsk May 19, 2020
eb6bbf1
Updated service url in test/render
kelsk May 19, 2020
a2ca8b5
Updated tests with urls & removed incorrect assertion
kelsk May 19, 2020
13fb1a0
updated POST request test
kelsk May 19, 2020
3084e6f
updated POST request test
kelsk May 19, 2020
829039b
removed 'then' from renderer test
kelsk May 19, 2020
b7a7eaa
test modifications
kelsk May 19, 2020
0a6e84c
Reconfigured serviceUrl
kelsk May 19, 2020
719b304
Removed sinon
kelsk May 21, 2020
5cfb4e6
Updated region tags
kelsk May 21, 2020
59e9e13
Updated valid request test
kelsk May 21, 2020
77d997c
Update: node 10 => node 12
kelsk May 27, 2020
9f9e9bd
Added end to end tests
kelsk Jun 4, 2020
258b7f2
Update run/markdown-preview/editor/test/system.test.js
kelsk Jun 4, 2020
ef89135
Merge branch 'master' into markdown
kelsk Jun 4, 2020
4fbb5f4
Added test to system.test.js
kelsk Jun 4, 2020
b071dfb
Fixed npm test
kelsk Jun 4, 2020
965b1b6
Merge branch 'markdown' of https://github.com/kelsk/nodejs-docs-sampl…
kelsk Jun 4, 2020
6bfc88b
Fixed renderer test
kelsk Jun 4, 2020
0d2d33a
Updated shell permissions
kelsk Jun 4, 2020
4658d62
Updated cleanup func
kelsk Jun 8, 2020
f449c88
Merge branch 'master' into markdown
kelsk Jun 8, 2020
9cc0974
Update var exports
kelsk Jun 8, 2020
f8483e2
Merge branch 'markdown' of https://github.com/kelsk/nodejs-docs-sampl…
kelsk Jun 8, 2020
ef43218
Added service-name.sh
kelsk Jun 9, 2020
ce5ff21
Merge branch 'master' into markdown
averikitsch Jun 9, 2020
0806459
Removed service-name.sh
kelsk Jun 9, 2020
e3b2703
Merge branch 'markdown' of https://github.com/kelsk/nodejs-docs-sampl…
kelsk Jun 9, 2020
bc1b999
Move service.sh functions into runner.sh
kelsk Jun 10, 2020
1a174f0
Merge branch 'master' into markdown
kelsk Jun 10, 2020
71eafed
Added check for BASE_URL
kelsk Jun 10, 2020
45e4ca4
Merge branch 'markdown' of https://github.com/kelsk/nodejs-docs-sampl…
kelsk Jun 10, 2020
9ed8ef5
Fixed system.test env
kelsk Jun 10, 2020
44af029
Add check for BASE_URL var
kelsk Jun 11, 2020
c4a152f
Added id token
kelsk Jun 12, 2020
35e5795
Merge branch 'master' into markdown
kelsk Jun 12, 2020
57aa5ee
Fixed test; removed allow-auth flag
kelsk Jun 12, 2020
9d2028a
Merge branch 'markdown' of https://github.com/kelsk/nodejs-docs-sampl…
kelsk Jun 12, 2020
a31c320
Added retry to http requests
kelsk Jun 15, 2020
a80a257
Merge branch 'master' into markdown
kelsk Jun 16, 2020
46b2110
Updated timeout on Renderer test
kelsk Jun 16, 2020
92ce020
Merge branch 'markdown' of https://github.com/kelsk/nodejs-docs-sampl…
kelsk Jun 16, 2020
84b51f8
Removed all timeouts from tests
kelsk Jun 16, 2020
e42a9ae
Removed retry from render.js
kelsk Jun 16, 2020
737e495
Add region tag 'run_secure_request_do'
kelsk Jun 17, 2020
6e57917
Fix endpoint syntax
kelsk Jun 19, 2020
e1ac8c8
Merge branch 'master' into system-test
kelsk Jun 19, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions run/markdown-preview/editor/test/system.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ describe('End-to-End Tests', () => {
},
retry: 1
};
const response = await got('/', options);
const response = await got('', options);
assert.strictEqual(response.statusCode, 200);
});

Expand All @@ -54,7 +54,7 @@ describe('End-to-End Tests', () => {
},
retry: 1
};
const response = await got('/render', options);
const response = await got('render', options);
assert.strictEqual(response.statusCode, 200);
assert.strictEqual(response.body, '<p><strong>markdown</strong></p>\n');
});
Expand Down