fix(cloud-sql): update unclear configuration in postgres connection sample #1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Please update the PR title to match our commit message convention. |
shubha-rajan
changed the title
shubha-rajan
changed the title
kurtisvg
suggested changes
Apr 27, 2020
cloud-sql/postgres/knex/server.js
Outdated
| // [START cloud_sql_postgres_knex_lifetime] | ||
| // 'idleTimeoutMillis' is the number of milliseconds a connection must sit idle in the pool | ||
| // and not be checked out before it is automatically closed. | ||
| knex.client.pool.idleTimeoutMillis = 600000; // 10 minutes |
There was a problem hiding this comment.
Same as the other PR - similar arguments are in different places for other samples. Can we move this into connection count and see if there is a "max lifetime" parameter?
There was a problem hiding this comment.
There isn't a max lifetime parameter (knex uses the same underlying pool implementation as mssql) so we'll probably have to leave this sample blank like in the mysql sample.
There was a problem hiding this comment.
SGTM - make sure when we update the "Connecting to Cloud SQL" page we include a similar line for SQL Server.
kurtisvg
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1697