Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCF: delete extraneous getmetrics sample #1734

Merged
merged 1 commit into from
Apr 22, 2020
Merged

GCF: delete extraneous getmetrics sample #1734

merged 1 commit into from
Apr 22, 2020

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented Apr 22, 2020

Not used in the docs any more.

@ace-n ace-n requested a review from fhinkel April 22, 2020 00:43
@ace-n ace-n requested a review from grant as a code owner April 22, 2020 00:43
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 22, 2020
@ace-n ace-n added the automerge Merge the pull request once unit tests and other checks pass. label Apr 22, 2020
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@ace-n ace-n removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 22, 2020
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

Copy link
Contributor

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My favorite kind of PR!

@fhinkel fhinkel merged commit 2c80c99 into master Apr 22, 2020
@fhinkel fhinkel deleted the delete-getmetrics branch April 22, 2020 17:55
ace-n pushed a commit that referenced this pull request May 18, 2020
ace-n pushed a commit that referenced this pull request May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants