Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): run/logging-manual test failures (#1637) #1680

Merged
merged 2 commits into from
Mar 31, 2020

Conversation

grayside
Copy link
Collaborator

Fixes #1637

run/logging-manual tests started failing due to a compatibility break in upgrading to got v10 #1557. This was not caught because the broken got feature is only used in system tests.

@grayside grayside self-assigned this Mar 30, 2020
@grayside grayside requested a review from fhinkel March 30, 2020 21:25
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 30, 2020
Copy link
Contributor

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! Can I made the presubmit required?

@fhinkel fhinkel added kokoro:run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Mar 31, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 31, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 0822b53 into master Mar 31, 2020
@grayside
Copy link
Collaborator Author

@fhinkel I don't have good insight into whether it's been proving flaky. If it seems stable to you I'm okay with making it required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mocha Tests: can be reached by an HTTP request failed
4 participants