Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list_datasets_and_projects sample #161

Merged
merged 11 commits into from
Aug 10, 2016
Merged

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented Aug 5, 2016

Used here

// See the License for the specific language governing permissions and
// limitations under the License.

/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to

/**
 * Command-line application to list all projects and datasets in BigQuery.
 *
 * This sample is used on this page:
 *
 *   https://cloud.google.com/bigquery/docs/managing_jobs_datasets_projects
 */

@ace-n ace-n force-pushed the list_datasets_and_projects branch from fa148fe to 88b8881 Compare August 8, 2016 18:12
});

bigquery.getDatasets(function (err, datasets, nextQuery, apiResponse) {
// Quit on error
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need these comments?

@ace-n ace-n force-pushed the list_datasets_and_projects branch from e7c8c53 to 0c55c13 Compare August 8, 2016 22:49
it('should require a Project ID', function () {
assert.throws(
function () {
example.listDatasets(null, null);
Copy link
Contributor Author

@ace-n ace-n Aug 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the null, null be removed? (It's semantically unnecessary, but it shows that this method can accept 2 parameters.)

@jmdobry jmdobry merged commit 5858cc1 into master Aug 10, 2016
@ace-n ace-n deleted the list_datasets_and_projects branch August 24, 2016 20:12
ace-n pushed a commit that referenced this pull request Nov 7, 2018
#161 makes this repo dependent on Node 8+ - this PR updates `package.json` to reflect that.
@ace-n ace-n mentioned this pull request Nov 7, 2018
kweinmeister pushed a commit that referenced this pull request Nov 7, 2022
kweinmeister pushed a commit that referenced this pull request Nov 8, 2022
kweinmeister pushed a commit that referenced this pull request Nov 8, 2022
kweinmeister pushed a commit that referenced this pull request Nov 10, 2022
* fix: drop support for node.js 4.x and 9.x

* moar fixing
ace-n pushed a commit that referenced this pull request Nov 11, 2022
* fix: drop support for node.js 4.x and 9.x

* moar fixing
ace-n pushed a commit that referenced this pull request Nov 11, 2022
* fix: drop support for node.js 4.x and 9.x

* moar fixing
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
* updated CHANGELOG.md

* updated package.json

* updated samples/package.json
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
* updated CHANGELOG.md

* updated package.json

* updated samples/package.json
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
* updated CHANGELOG.md

* updated package.json

* updated samples/package.json
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
* updated CHANGELOG.md

* updated package.json

* updated samples/package.json
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
* updated CHANGELOG.md

* updated package.json

* updated samples/package.json
unforced pushed a commit that referenced this pull request Nov 17, 2022
unforced pushed a commit that referenced this pull request Nov 17, 2022
ace-n pushed a commit that referenced this pull request Nov 17, 2022
* updated CHANGELOG.md

* updated package.json

* updated samples/package.json
ahrarmonsur pushed a commit that referenced this pull request Nov 17, 2022
kweinmeister pushed a commit that referenced this pull request Jan 11, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants