-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cloud-sql/mysql sample #1552
Conversation
fhinkel
commented
Nov 26, 2019
•
edited
Loading
edited
- Update Node version to 10 for GAE Standard.
- Delete repo-tools.
- Clean up package.json
cloud-sql/mysql/mysql/README.md
Outdated
@@ -74,22 +74,6 @@ command: | |||
gcloud app browse | |||
``` | |||
|
|||
## Deploy to Google App Engine Flexible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we deleting the Flex instructions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't see it used in our docs. We recommend people use GAE Standard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm +1 to removing flex now that Cloud Run is GA. Question - do we have broad guidance to do this across the docs and sample sets? Would be good to have something written down.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We moved almost all samples to GAE Standard more than a year ago. @michaelawyu was there a document for those changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We definitely don't want to do that for this sample. There are differences between how Standard / Flex interact with Cloud SQL and part of the point of these samples to show how to do that for each.
Update Node version to 10 for GAE Standard. Delete repo-tools. Clean up package.json
416f48f
to
af7c8fb
Compare