Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cloud-sql/mysql sample #1552

Merged
merged 1 commit into from
Nov 27, 2019
Merged

Update cloud-sql/mysql sample #1552

merged 1 commit into from
Nov 27, 2019

Conversation

fhinkel
Copy link
Contributor

@fhinkel fhinkel commented Nov 26, 2019 •
edited
Loading

  • Update Node version to 10 for GAE Standard.
  • Delete repo-tools.
  • Clean up package.json

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 26, 2019
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 26, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 26, 2019
kurtisvg
kurtisvg suggested changes Nov 26, 2019
View reviewed changes
cloud-sql/mysql/mysql/README.md Outdated
@@ -74,22 +74,6 @@ command:
gcloud app browse
```

## Deploy to Google App Engine Flexible
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we deleting the Flex instructions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see it used in our docs. We recommend people use GAE Standard.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm +1 to removing flex now that Cloud Run is GA. Question - do we have broad guidance to do this across the docs and sample sets? Would be good to have something written down.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We moved almost all samples to GAE Standard more than a year ago. @michaelawyu was there a document for those changes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We definitely don't want to do that for this sample. There are differences between how Standard / Flex interact with Cloud SQL and part of the point of these samples to show how to do that for each.

cloud-sql/mysql/mysql/package.json Show resolved Hide resolved
@fhinkel
Update cloud-sql/mysql sample
af7c8fb 
Update Node version to 10 for GAE Standard.
Delete repo-tools.
Clean up package.json
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 27, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 27, 2019
@fhinkel fhinkel merged commit de32e42 into master Nov 27, 2019
@fhinkel fhinkel deleted the repo-tools-mysql branch November 27, 2019 00:32
This was referenced Dec 23, 2020
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Sep 5, 2021
Open
Open
Open
Open
This was referenced Jan 12, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Feb 10, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Oct 27, 2023
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

@kurtisvg kurtisvg kurtisvg approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fhinkel @JustinBeckwith @kurtisvg @googlebot @kokoro-team