Fix iot test by using new method name #1528
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This was referenced Oct 25, 2019
Closed
gguuss
approved these changes
Oct 25, 2019
|
Tests are passing for me locally, merging when green. |
gguuss
added
kokoro:force-run
kokoro-team
removed
kokoro:run
|
I will see about getting the breaking change rolled back. |
fhinkel
approved these changes
Oct 25, 2019
fhinkel
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
gguuss
added
the
do not merge
|
I'll see if we can revert the breaking change |
fhinkel
changed the title
|
does it make sense to resolve the conflicting file? @gguuss |
|
Yes, let's just go ahead and allow the breaking change in this case, I'll try and track down the other code samples that are out there requiring changes. |
gguuss
added
kokoro:force-run
kokoro-team
removed
kokoro:run
|
@mesmacosta Thank you so much for making the PR; we were able to get this resolved in the update to the IoT Client library version 1.3.1 so I'm going to go ahead and close this, favoring skipping the additional record of the breaking change as done in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that this test started breaking in another PR that I opened.
Doing a quick analysis:
The iot/manager test failing seem to be related to this change:
googleapis/nodejs-iot@68a1d6e
Method name changed, but test from sample code was not updated.
client.registryPath -> client.deviceRegistryPath
So I can't say for sure, because I don't know the full extend of that commit, but this small change might fix it, I'd like to run it in the integrated environment to see if it will solve.
@fhinkel