Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete dead link on README #1507

Merged

Conversation

iganari
Copy link
Contributor

@iganari iganari commented Oct 5, 2019

I found a broken link in the README .

This is when the link is deleted .

66dcad8#diff-04c6e90faac2675aa89e2176d2eec7d8

As a result of checking the contents, you may delete the wording of README

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Oct 5, 2019
@iganari
Copy link
Contributor Author

iganari commented Oct 5, 2019

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Oct 5, 2019
@fhinkel
Copy link
Contributor

fhinkel commented Oct 7, 2019

@iganari Thank you. @djmailhot please have a look. Thanks

@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 8, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 8, 2019
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 8, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 8, 2019
@fhinkel fhinkel merged commit afa34e5 into GoogleCloudPlatform:master Oct 8, 2019
@iganari iganari deleted the feature/modify-readme-link branch October 26, 2019 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants