Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: prefer template strings #1492

Closed
wants to merge 4 commits into from
Closed

refactor: prefer template strings #1492

wants to merge 4 commits into from

Conversation

grant
Copy link
Contributor

@grant grant commented Sep 23, 2019

Prefer template strings throughout this repo. (Currently shows ESLint warnings)
See #1367

@grant grant requested a review from ace-n September 23, 2019 12:52
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 23, 2019
kurtisvg
kurtisvg approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@kurtisvg kurtisvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for /cloud-sql/

@ace-n
Copy link
Contributor

ace-n commented Sep 23, 2019 via email

gguuss
gguuss approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for iot, thank you for the free refactor :)

@grant
Copy link
Contributor Author

grant commented Oct 4, 2019

Well, this looks like a different PR added template strings.

@grant grant closed this Oct 4, 2019
@fhinkel fhinkel deleted the grant_template_strings branch December 3, 2019 00:18
@snyk-bot snyk-bot mentioned this pull request Jan 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gguuss gguuss gguuss approved these changes

@kurtisvg kurtisvg kurtisvg approved these changes

@ace-n ace-n Awaiting requested review from ace-n

@djmailhot djmailhot Awaiting requested review from djmailhot

@santhoshvaddi santhoshvaddi Awaiting requested review from santhoshvaddi

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@grant @ace-n @gguuss @kurtisvg @googlebot