-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Remove functions_background_synchronous #1490
Conversation
Not a bad idea, but can you update the relevant doc first? |
I've created CL 270366828. Note, I'm not able to stage due to updates to Devsite 2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if @labtopia approves the docs changes.
The error states:
But this has been removed. Not sure what is happening. |
The broken test is completely separate from the changes made in this PR.
It's not in the Since this PR is approved and |
Removes
functions_background_synchronous
.This sample do not show any new feature that is not shown in other samples.
It is also is not a useful sample to duplicate across languages.
Docs: https://cloud.google.com/functions/docs/writing/background#terminating_background_functions
CL: cl/270366828