Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove functions_background_synchronous #1490

Merged
merged 6 commits into from
Oct 11, 2019

Conversation

grant
Copy link
Contributor

@grant grant commented Sep 20, 2019

Removes functions_background_synchronous.
This sample do not show any new feature that is not shown in other samples.
It is also is not a useful sample to duplicate across languages.

Docs: https://cloud.google.com/functions/docs/writing/background#terminating_background_functions
CL: cl/270366828

@grant grant requested a review from ace-n September 20, 2019 20:30
@grant grant self-assigned this Sep 20, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 20, 2019
@ace-n
Copy link
Contributor

ace-n commented Sep 20, 2019

Not a bad idea, but can you update the relevant doc first?

@grant
Copy link
Contributor Author

grant commented Sep 23, 2019

Not a bad idea, but can you update the relevant doc first?

I've created CL 270366828. Note, I'm not able to stage due to updates to Devsite 2.

Copy link
Contributor

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if @labtopia approves the docs changes.

@grant grant added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 25, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 25, 2019
@grant
Copy link
Contributor Author

grant commented Oct 11, 2019

The error states:

  ✓ should make a promise request (498ms)
  functions_background_synchronous
    1) should return synchronously
    ✓ should throw an error


  2 passing (2s)
  1 failing

  1) functions_background_synchronous
       should return synchronously:
     TypeError: program.helloSynchronous is not a function
      at Context.it (test/index.test.js:73:15)

But this has been removed. Not sure what is happening.

@grant grant added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 11, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 11, 2019
@grant
Copy link
Contributor Author

grant commented Oct 11, 2019

The broken test is completely separate from the changes made in this PR.

Internal CI (run/logging-manual) — Tests failed.

It's not in the functions/ directory.

Since this PR is approved and functions/ test pass, merging.

@grant grant merged commit 5d51a36 into master Oct 11, 2019
@grant grant deleted the grant_functions_background_synchronous branch October 11, 2019 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants