Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run: use node:10-slim #1470

Merged
merged 4 commits into from
Sep 9, 2019
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions run/image-processing/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
# Use of this source code is governed by the Apache 2.0
# license that can be found in the LICENSE file.

# Use the official Node.js 10 image.
# Use the official lightweight Node.js 10 image.
# https://hub.docker.com/_/node
FROM node:10
FROM node:10-slim

# [START run_imageproc_dockerfile_imagemagick]

Expand All @@ -27,9 +27,9 @@ WORKDIR /usr/src/app
COPY package*.json ./

# Install dependencies.
RUN npm install --production
# If you add a package-lock.json, speed your build by switching to 'npm ci'.
# If you add a package-lock.json speed your build by switching to 'npm ci'.
# RUN npm ci --only=production
RUN npm install --production

# Copy local code to the container image.
COPY . .
Expand Down
3 changes: 3 additions & 0 deletions run/image-processing/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ For more details on how to work with this sample read the [Google Cloud Run Node

* **express**: Web server framework
* **body-parser**: express middleware for request payload processing
* **[gm](https://github.com/aheckmann/gm#readme)**: ImageMagick integration library.
* **@google-cloud/storage**: Google Cloud Storage client library.
* **@google-cloud/vision**: Cloud Vision API client library.

## Environment Variables

Expand Down
8 changes: 4 additions & 4 deletions run/logging-manual/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
# Use of this source code is governed by the Apache 2.0
# license that can be found in the LICENSE file.

# Use the official Node.js 10 image.
# Use the official lightweight Node.js 10 image.
# https://hub.docker.com/_/node
FROM node:10
FROM node:10-slim

# Create and change to the app directory.
WORKDIR /usr/src/app
Expand All @@ -15,9 +15,9 @@ WORKDIR /usr/src/app
COPY package*.json ./

# Install dependencies.
RUN npm install
# For production deploys, add a package-lock.json and use 'npm ci'.
# If you add a package-lock.json speed your build by switching to 'npm ci'.
# RUN npm ci --only=production
RUN npm install --production

# Copy local code to the container image.
COPY . .
Expand Down
1 change: 0 additions & 1 deletion run/logging-manual/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
},
"devDependencies": {
"@google-cloud/logging": "^5.1.2",
"@google-cloud/nodejs-repo-tools": "^3.3.0",
"mocha": "^6.1.4"
}
}
3 changes: 3 additions & 0 deletions run/pubsub/.envrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export GOOGLE_CLOUD_PROJECT=adamross-svls-kibble
export SERVICE_NAME=pubsub-tutorial
export DOCKER_IMAGE_TAG=nodejs
8 changes: 4 additions & 4 deletions run/pubsub/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@

# [START run_pubsub_dockerfile]

# Use the official Node.js 10 image.
# Use the official lightweight Node.js 10 image.
# https://hub.docker.com/_/node
FROM node:10
FROM node:10-slim

# Create and change to the app directory.
WORKDIR /usr/src/app
Expand All @@ -17,9 +17,9 @@ WORKDIR /usr/src/app
COPY package*.json ./

# Install dependencies.
RUN npm install --production
# If you add a package-lock.json, speed your build by switching to 'npm ci'.
# If you add a package-lock.json speed your build by switching to 'npm ci'.
# RUN npm ci --only=production
RUN npm install --production

# Copy local code to the container image.
COPY . .
Expand Down
5 changes: 1 addition & 4 deletions run/pubsub/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,4 @@ For more details on how to work with this sample read the [Google Cloud Run Node
## Dependencies

* **express**: Web server framework.
* **body-parser**: express middleware for request payload processing.
* **[gm](https://github.com/aheckmann/gm#readme)**: ImageMagick integration library.
* **@google-cloud/storage**: Google Cloud Storage client library.
* **@google-cloud/vision**: Cloud Vision API client library.
* **body-parser**: express middleware for request payload processing.