Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update function signatures for NodeJS 8 (#1318) #1335

Merged
merged 11 commits into from
Jun 4, 2019
Merged

Update function signatures for NodeJS 8 (#1318) #1335

merged 11 commits into from
Jun 4, 2019

Conversation

jpatokal
Copy link
Member

@jpatokal jpatokal commented Jun 4, 2019

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 4, 2019
fhinkel
fhinkel approved these changes Jun 4, 2019
View reviewed changes
Copy link
Contributor

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fhinkel fhinkel added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 4, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 4, 2019
@fhinkel fhinkel merged commit 6085e23 into GoogleCloudPlatform:master Jun 4, 2019
@sdenef-adeo sdenef-adeo mentioned this pull request Jul 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jpatokal @fhinkel @googlebot @kokoro-team