-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error in documentation #1310
Conversation
@noerog Could you have a look at this healthcare API question? Thank you! |
Thanks @samuelli . I'll merge this as soon as CI finishes. |
Could you fix the lint problems please :) |
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
This matches the code in
googleapis
. However, it is entirely plausible that this documentation is correct and thegoogleapis
function needs to be updated.See https://github.com/googleapis/google-api-nodejs-client/blob/6817c39728b199b82af5478de5aef2cda51e969c/src/apis/healthcare/v1beta1.ts#L1290-L1364 for implementation function.