Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in documentation #1310

Merged
merged 6 commits into from
Jun 4, 2019
Merged

Conversation

samuelli
Copy link
Contributor

This matches the code in googleapis. However, it is entirely plausible that this documentation is correct and the googleapis function needs to be updated.

See https://github.com/googleapis/google-api-nodejs-client/blob/6817c39728b199b82af5478de5aef2cda51e969c/src/apis/healthcare/v1beta1.ts#L1290-L1364 for implementation function.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 20, 2019
@fhinkel
Copy link
Contributor

fhinkel commented May 21, 2019

@noerog Could you have a look at this healthcare API question? Thank you!

@fhinkel
Copy link
Contributor

fhinkel commented May 30, 2019

Thanks @samuelli . I'll merge this as soon as CI finishes.

@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 30, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 30, 2019
@fhinkel
Copy link
Contributor

fhinkel commented May 30, 2019

Could you fix the lint problems please :)

@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 4, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 4, 2019
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 4, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 4, 2019
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jun 4, 2019
@fhinkel fhinkel added kokoro:run Add this label to force Kokoro to re-run the tests. cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jun 4, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 4, 2019
@fhinkel fhinkel merged commit 5820a3f into GoogleCloudPlatform:master Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants