Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop/start instances by label instead of name #1293

Merged
merged 6 commits into from
May 23, 2019
Merged

Stop/start instances by label instead of name #1293

merged 6 commits into from
May 23, 2019

Conversation

jpatokal
Copy link
Member

Update code to match changes to Scheduling Compute Instances with Cloud Scheduler

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 17, 2019
ace-n
ace-n approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than a few nits - feel free to merge when fixed.

functions/scheduleinstance/test/index.test.js Outdated Show resolved Hide resolved
functions/scheduleinstance/index.js Outdated Show resolved Hide resolved
functions/scheduleinstance/index.js Outdated Show resolved Hide resolved
@ace-n ace-n merged commit 359ddc5 into GoogleCloudPlatform:master May 23, 2019
@djmailhot djmailhot mentioned this pull request Jun 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ace-n ace-n ace-n approved these changes

Assignees

@ace-n ace-n

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpatokal @ace-n @googlebot