Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functions #120

Merged
merged 7 commits into from
Jun 8, 2016
Merged

Functions #120

merged 7 commits into from
Jun 8, 2016

Conversation

jmdobry
Copy link
Member

@jmdobry jmdobry commented Jun 7, 2016

No description provided.

@jmdobry jmdobry self-assigned this Jun 7, 2016
@jmdobry jmdobry assigned theacodes and jsimonweb and unassigned jmdobry Jun 7, 2016
@jmdobry
Copy link
Member Author

jmdobry commented Jun 7, 2016

@jonparrott I'll stop adding to this PR so it doesn't get huge, and I'll continue with a branch of this branch.

@theacodes
Copy link

@jmdobry are you ready for this to be reviewed?

@@ -0,0 +1,54 @@
<img src="https://avatars2.githubusercontent.com/u/2810941?v=3&s=96" alt="Google Cloud Platform logo" title="Google Cloud Platform" align="right" height="96" width="96"/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there not a tutorial for this on devsite? Would it be more valuable to house most of this documentation there?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will be a more complete tutorial added to devsite.

// Create a pubsub client.
var pubsub = gcloud.pubsub();

module.exports = {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems you should give this the same treatment as the other samples and define functions and assign them to exports.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@codecov-io
Copy link

codecov-io commented Jun 8, 2016

Current coverage is 79.12%

Merging #120 into master will increase coverage by 0.91%

@@             master       #120   diff @@
==========================================
  Files            35         39     +4   
  Lines          1528       1614    +86   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1195       1277    +82   
- Misses          333        337     +4   
  Partials          0          0          

Powered by Codecov. Last updated by 92b9cb5...60cd076

@theacodes
Copy link

This LGTM, once Travis is green.

ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
unforced pushed a commit that referenced this pull request Nov 17, 2022
* updated CHANGELOG.md [ci skip]

* updated package.json [ci skip]

* updated samples/package.json [ci skip]
jsimonweb pushed a commit to jsimonweb/nodejs-docs-samples that referenced this pull request Dec 12, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
irataxy pushed a commit that referenced this pull request Jan 14, 2023
🤖 I have created a release \*beep\* \*boop\*
---
### [1.7.2](https://www.github.com/googleapis/nodejs-video-transcoder/compare/v1.7.1...v1.7.2) (2021-10-13)


### Bug Fixes

* remove Encryption settings that were published due to a sync issue BREAKING CHANGE: requests specifying Encryption settings are rejected by the server ([1509f5c](https://www.github.com/googleapis/nodejs-video-transcoder/commit/1509f5ce94912bb64fc48103bbc21fe79d81b277))
* update nodejs package name to video-transcoder ([#119](https://www.github.com/googleapis/nodejs-video-transcoder/issues/119)) ([1509f5c](https://www.github.com/googleapis/nodejs-video-transcoder/commit/1509f5ce94912bb64fc48103bbc21fe79d81b277))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
irataxy pushed a commit that referenced this pull request Jan 18, 2023
🤖 I have created a release \*beep\* \*boop\*
---
### [1.7.2](https://www.github.com/googleapis/nodejs-video-transcoder/compare/v1.7.1...v1.7.2) (2021-10-13)


### Bug Fixes

* remove Encryption settings that were published due to a sync issue BREAKING CHANGE: requests specifying Encryption settings are rejected by the server ([1509f5c](https://www.github.com/googleapis/nodejs-video-transcoder/commit/1509f5ce94912bb64fc48103bbc21fe79d81b277))
* update nodejs package name to video-transcoder ([#119](https://www.github.com/googleapis/nodejs-video-transcoder/issues/119)) ([1509f5c](https://www.github.com/googleapis/nodejs-video-transcoder/commit/1509f5ce94912bb64fc48103bbc21fe79d81b277))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants