Functions #120
Merged
Functions #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jonparrott I'll stop adding to this PR so it doesn't get huge, and I'll continue with a branch of this branch. |
|
@jmdobry are you ready for this to be reviewed? |
| @@ -0,0 +1,54 @@ | |||
| <img src="https://avatars2.githubusercontent.com/u/2810941?v=3&s=96" alt="Google Cloud Platform logo" title="Google Cloud Platform" align="right" height="96" width="96"/> | |||
There was a problem hiding this comment.
Is there not a tutorial for this on devsite? Would it be more valuable to house most of this documentation there?
There was a problem hiding this comment.
There will be a more complete tutorial added to devsite.
| // Create a pubsub client. | ||
| var pubsub = gcloud.pubsub(); | ||
|
|
||
| module.exports = { |
There was a problem hiding this comment.
Seems you should give this the same treatment as the other samples and define functions and assign them to exports.
Current coverage is 79.12%@@ master #120 diff @@
==========================================
Files 35 39 +4
Lines 1528 1614 +86
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1195 1277 +82
- Misses 333 337 +4
Partials 0 0
|
|
This LGTM, once Travis is green. |
This was referenced Nov 14, 2022
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 16, 2022
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 16, 2022
unforced
pushed a commit
that referenced
this pull request
Nov 17, 2022
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
NimJay
pushed a commit
that referenced
this pull request
Nov 19, 2022
NimJay
pushed a commit
that referenced
this pull request
Nov 19, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 21, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 21, 2022
jsimonweb
pushed a commit
to jsimonweb/nodejs-docs-samples
that referenced
this pull request
Dec 12, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
irataxy
pushed a commit
that referenced
this pull request
Jan 14, 2023
🤖 I have created a release \*beep\* \*boop\* --- ### [1.7.2](https://www.github.com/googleapis/nodejs-video-transcoder/compare/v1.7.1...v1.7.2) (2021-10-13) ### Bug Fixes * remove Encryption settings that were published due to a sync issue BREAKING CHANGE: requests specifying Encryption settings are rejected by the server ([1509f5c](https://www.github.com/googleapis/nodejs-video-transcoder/commit/1509f5ce94912bb64fc48103bbc21fe79d81b277)) * update nodejs package name to video-transcoder ([#119](https://www.github.com/googleapis/nodejs-video-transcoder/issues/119)) ([1509f5c](https://www.github.com/googleapis/nodejs-video-transcoder/commit/1509f5ce94912bb64fc48103bbc21fe79d81b277)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
irataxy
pushed a commit
that referenced
this pull request
Jan 18, 2023
🤖 I have created a release \*beep\* \*boop\* --- ### [1.7.2](https://www.github.com/googleapis/nodejs-video-transcoder/compare/v1.7.1...v1.7.2) (2021-10-13) ### Bug Fixes * remove Encryption settings that were published due to a sync issue BREAKING CHANGE: requests specifying Encryption settings are rejected by the server ([1509f5c](https://www.github.com/googleapis/nodejs-video-transcoder/commit/1509f5ce94912bb64fc48103bbc21fe79d81b277)) * update nodejs package name to video-transcoder ([#119](https://www.github.com/googleapis/nodejs-video-transcoder/issues/119)) ([1509f5c](https://www.github.com/googleapis/nodejs-video-transcoder/commit/1509f5ce94912bb64fc48103bbc21fe79d81b277)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.