Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iot: add mqtt gateway samples to GA #1169

Merged
merged 7 commits into from
Feb 20, 2019
Merged

iot: add mqtt gateway samples to GA #1169

merged 7 commits into from
Feb 20, 2019

Conversation

hongalex
Copy link
Contributor

  • moved MQTT gateway samples from gateway to mqtt_example
  • refactored existing cloudiot_mqtt_example_nodejs.js sample to support different commands
  • added tests for MQTT gateway samples

@hongalex hongalex requested a review from gguuss February 19, 2019 10:10
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 19, 2019
Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few nits on examples variables in comments that you can ignore and address later or get in this PR.

description: 'Public key format for devices.',
requiresArg: true,
choices: ['RS256_PEM', 'RS256_X509_PEM', 'ES256_PEM', 'ES256_X509_PEM'],
choices: ['RSA_PEM', 'RSA_X509_PEM', 'ES256_PEM', 'ES256_X509_PEM'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. We should probably add these options to the other samples.

iot/mqtt_example/cloudiot_mqtt_example_nodejs.js Outdated Show resolved Hide resolved
iot/mqtt_example/cloudiot_mqtt_example_nodejs.js Outdated Show resolved Hide resolved
iot/mqtt_example/cloudiot_mqtt_example_nodejs.js Outdated Show resolved Hide resolved
@hongalex hongalex added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 20, 2019
@kokoro-team kokoro-team removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 20, 2019
@hongalex hongalex merged commit eca6a65 into master Feb 20, 2019
@hongalex hongalex deleted the iot-gateway-mqtt-ga branch February 20, 2019 01:39
This was referenced Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants