-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Websockets sample + add tests #1001
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
# Node.js websockets sample for Google App Engine | ||
|
||
This sample demonstrates how to use websockets on | ||
[Google App Engine Flexible Environment][appengine] with Node.js. | ||
|
||
* [Setup](#setup) | ||
* [Running locally](#running-locally) | ||
* [Deploying to App Engine](#deploying-to-app-engine) | ||
* [Running the tests](#running-the-tests) | ||
|
||
## Setup | ||
|
||
Before you can run or deploy the sample, you need to do the following: | ||
|
||
1. Refer to the [appengine/README.md][readme] file for instructions on | ||
running and deploying. | ||
1. Install dependencies: | ||
|
||
With `npm`: | ||
|
||
npm install | ||
|
||
or with `yarn`: | ||
|
||
yarn install | ||
|
||
## Running locally | ||
|
||
With `npm`: | ||
|
||
npm start | ||
|
||
or with `yarn`: | ||
|
||
yarn start | ||
|
||
## Deploying to App Engine | ||
|
||
With `npm`: | ||
|
||
npm run deploy | ||
|
||
or with `yarn`: | ||
|
||
yarn run deploy | ||
|
||
## Running the tests | ||
|
||
See [Contributing][contributing]. | ||
|
||
[appengine]: https://cloud.google.com/appengine/docs/flexible/nodejs | ||
[readme]: ../README.md | ||
[contributing]: https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/master/CONTRIBUTING.md | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
/** | ||
* Copyright 2018, Google LLC. | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
'use strict'; | ||
|
||
// [START appengine_websockets_app] | ||
const app = require('express')(); | ||
app.set('view engine', 'pug'); | ||
|
||
const server = require('http').Server(app); | ||
const io = require('socket.io')(server); | ||
|
||
app.get('/', (req, res) => { | ||
res.render('index.pug'); | ||
}); | ||
|
||
io.on('connection', (socket) => { | ||
socket.on('chat message', (msg) => { | ||
io.emit('chat message', msg); | ||
}); | ||
}); | ||
|
||
if (module === require.main) { | ||
const PORT = process.env.PORT || 8080; | ||
server.listen(PORT, () => { | ||
console.log(`App listening on port ${PORT}`); | ||
console.log('Press Ctrl+C to quit.'); | ||
}); | ||
} | ||
// [END appengine_websockets_app] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
# Copyright 2018, Google LLC. | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
# [START appengine_websockets_yaml] | ||
runtime: nodejs | ||
env: flex | ||
|
||
# Use only a single instance, so that this local-memory-only chat app will work | ||
# consistently with multiple users. To work across multiple instances, an | ||
# extra-instance messaging system or data store would be needed. | ||
manual_scaling: | ||
instances: 1 | ||
|
||
network: | ||
session_affinity: true | ||
# [END appengine_websockets_yaml] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
{ | ||
"name": "appengine-websockets", | ||
"description": "Node.js websockets sample for Google App Engine", | ||
"version": "0.0.1", | ||
"private": true, | ||
"license": "Apache Version 2.0", | ||
"author": "Google Inc.", | ||
"engines": { | ||
"node": ">=4" | ||
}, | ||
"scripts": { | ||
"deploy": "gcloud app deploy", | ||
"start": "node app.js", | ||
"lint": "samples lint", | ||
"pretest": "npm run lint", | ||
"test": "node app.js & ava -T 30s test/*.js; killall node", | ||
"e2e-test": "samples test deploy" | ||
}, | ||
"dependencies": { | ||
"express": "4.15.4", | ||
"pug": "2.0.0-rc.3", | ||
"socket.io": "2.0.3" | ||
}, | ||
"devDependencies": { | ||
"@google-cloud/nodejs-repo-tools": "1.4.17", | ||
"puppeteer": "^1.11.0" | ||
}, | ||
"cloud-repo-tools": { | ||
"test": { | ||
"app": { | ||
"msg": "messages" | ||
} | ||
}, | ||
"requiresKeyFile": true, | ||
"requiresProjectId": true | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
/** | ||
* Copyright 2018, Google LLC. | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
'use strict'; | ||
|
||
const test = require('ava'); | ||
|
||
const puppeteer = require('puppeteer'); | ||
|
||
let browser, browserPage; | ||
|
||
test.before(async () => { | ||
browser = await puppeteer.launch(); | ||
browserPage = await browser.newPage(); | ||
}); | ||
|
||
test.after.always(async () => { | ||
await browser.close(); | ||
}); | ||
|
||
test('should process chat message', async (t) => { | ||
await browserPage.goto('http://localhost:8080'); | ||
|
||
await browserPage.evaluate(() => { | ||
document.querySelector('input').value = 'test'; | ||
document.querySelector('button').click(); | ||
}); | ||
|
||
await new Promise(resolve => setTimeout(resolve, 100)); | ||
|
||
const itemText = await browserPage.evaluate(() => document.querySelector('li').textContent); | ||
|
||
t.is(itemText, 'test'); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
//- Copyright 2018 Google LLC. | ||
//- | ||
//- Licensed under the Apache License, Version 2.0 (the "License"); | ||
//- you may not use this file except in compliance with the License. | ||
//- You may obtain a copy of the License at | ||
//- | ||
//- http://www.apache.org/licenses/LICENSE-2.0 | ||
//- | ||
//- Unless required by applicable law or agreed to in writing, software | ||
//- distributed under the License is distributed on an "AS IS" BASIS, | ||
//- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
//- See the License for the specific language governing permissions and | ||
//- limitations under the License. | ||
|
||
//- [START appengine_websockets_index] | ||
doctype html | ||
html(lang="en") | ||
head | ||
title Socket.IO chat on App Engine | ||
meta(charset="utf-8") | ||
style. | ||
* { margin: 0; padding: 0; box-sizing: border-box; } | ||
body { font: 13px Helvetica, Arial; } | ||
form { background: #000; padding: 3px; position: fixed; bottom: 0; width: 100%; } | ||
form input { border: 0; padding: 10px; width: 90%; margin-right: .5%; } | ||
form button { width: 9%; background: rgb(130, 224, 255); border: none; padding: 10px; } | ||
#messages { list-style-type: none; margin: 0; padding: 0; } | ||
#messages li { padding: 5px 10px; } | ||
#messages li:nth-child(odd) { background: #eee; } | ||
//- [START appengine_websockets_form] | ||
body | ||
ul(id="messages") | ||
form(action="") | ||
input(id="m" autocomplete="off") | ||
button Send | ||
//- [END appengine_websockets_form] | ||
|
||
script(src="/socket.io/socket.io.js") | ||
script(src="https://code.jquery.com/jquery-1.11.1.js") | ||
script. | ||
// [START appengine_websockets_js] | ||
$(function () { | ||
var socket = io(); | ||
$('form').submit(function(){ | ||
console.log($('#m').val()); | ||
socket.emit('chat message', $('#m').val()); | ||
$('#m').val(''); | ||
return false; | ||
}); | ||
socket.on('chat message', function(msg){ | ||
console.log(msg); | ||
$('#messages').append($('<li>').text(msg)); | ||
window.scrollTo(0, document.body.scrollHeight); | ||
}); | ||
}); | ||
// [END appengine_websockets_js] | ||
//- [END appengine_websockets_index] | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: we should omit copyright statement for app.yaml files