Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bigquery/tables code create table is broken #223

Closed
c0b opened this issue Sep 29, 2016 · 4 comments
Closed

bigquery/tables code create table is broken #223

c0b opened this issue Sep 29, 2016 · 4 comments
Assignees
Labels
🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@c0b
Copy link

c0b commented Sep 29, 2016

https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/master/bigquery/tables.js#L24

the createTable is defined with 4 arguments but called with only 3 arguments, caused runtime broken of callback not defined

function createTable (datasetId, tableId, schema, callback) {

https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/master/bigquery/tables.js#L233

var program = module.exports = {
  createTable: createTable,
  // ...
}

  .command('create <datasetId> <tableId>', 'Create a new table with the specified ID in the specified dataset.', {}, function (options) {
    program.createTable(options.datasetId, options.tableId, utils.makeHandler(false));
  })
@jmdobry
Copy link
Member

jmdobry commented Sep 29, 2016

Good catch! Sorry about that.

@jmdobry
Copy link
Member

jmdobry commented Nov 7, 2016

Fixed

@jmdobry jmdobry closed this as completed Nov 7, 2016
@c0b
Copy link
Author

c0b commented Nov 7, 2016

I feel it's in #244 but why don't you put Fixed #223 in your commit msg where you fixed it, then github would create connection between your commit to this issue, and automatically close this one; it's a general good practice because otherwise people need to spend time find out where or how you fix

@jmdobry
Copy link
Member

jmdobry commented Nov 7, 2016

I'm aware of this functionality, I had simply forgotten about this issue when I cleaned up the BigQuery samples. Here, I'll retroactively reference this issue:

@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 7, 2020
NimJay pushed a commit that referenced this issue Nov 19, 2022
* updated CHANGELOG.md

* updated package.json

* updated samples/package.json
NimJay pushed a commit that referenced this issue Nov 19, 2022
* updated CHANGELOG.md

* updated package.json

* updated samples/package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

4 participants