Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

googlesapis 49 causes failing tests in storage transfer #1747

Closed
fhinkel opened this issue Apr 27, 2020 · 4 comments · Fixed by #1812
Closed

googlesapis 49 causes failing tests in storage transfer #1747

fhinkel opened this issue Apr 27, 2020 · 4 comments · Fixed by #1812
Assignees
Labels
api: storage Issues related to the Cloud Storage API. api: storagetransfer Issues related to the Storage Transfer Service API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@fhinkel
Copy link
Contributor

fhinkel commented Apr 27, 2020

See #1784

@fhinkel fhinkel added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: storagetransfer Issues related to the Storage Transfer Service API. labels Apr 27, 2020
@meredithslota
Copy link
Contributor

I feel like this is actually @laylasells's domain.

@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels May 3, 2020
@fhinkel fhinkel added the api: storage Issues related to the Cloud Storage API. label May 7, 2020
@fhinkel
Copy link
Contributor Author

fhinkel commented May 18, 2020

@laylasells Could somebody look into this please? We're now 3 releases behind because we can't update any sample in the repo. Thanks!

@frankyn frankyn assigned frankyn and unassigned laylasells May 18, 2020
@frankyn
Copy link
Member

frankyn commented May 18, 2020

Hi @fhinkel, I'm taking a look. Apologies for the delay.

@frankyn
Copy link
Member

frankyn commented May 18, 2020

The example is inconsistent with how auth is currently documented at https://cloud.google.com/storage-transfer/docs/reference/rest/v1/transferJobs/list. I saw consistent failures of unauthorized failures.

Then I found: https://github.com/googleapis/google-auth-library-nodejs/blob/41b0cb7b3dbae1b264b7de1cae82648c402d5cc3/CHANGELOG.md#v200

I was able to fix the broken tests locally after updating the auth initialization in #1807. I want to make sure CI passes, but this might be the issue given auth is at 5.0.0 IIUC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. api: storagetransfer Issues related to the Storage Transfer Service API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants