Skip to content

Commit

Permalink
fix: Fixes GAE headless chrome region tags. See #834 (#1356)
Browse files Browse the repository at this point in the history
* fix: Fixes GAE headless chrome region tags. See #834

* Update app.js
  • Loading branch information
grant authored Jun 11, 2019
1 parent 773aa9e commit 6b290f0
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions appengine/headless-chrome/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ limitations under the License.
*/
'use strict';

// [START full_sample]
// [START gae_std_headless_chrome_full_sample]
const express = require('express');
const puppeteer = require('puppeteer');
const app = express();
Expand All @@ -32,11 +32,11 @@ app.use(async (req, res) => {
}

if (!browser) {
// [START browser]
// [START gae_std_headless_chrome_full_sample_browser]
browser = await puppeteer.launch({
args: ['--no-sandbox'],
});
// [END browser]
// [END gae_std_headless_chrome_full_sample_browser]
}

const page = await browser.newPage();
Expand All @@ -54,6 +54,6 @@ const server = app.listen(process.env.PORT || 8080, err => {
const {port} = server.address();
console.info(`App listening on port ${port}`);
});
// [END full_sample]
// [END gae_std_headless_chrome_full_sample]

module.exports = app;
4 changes: 2 additions & 2 deletions appengine/headless-chrome/app.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
# See the License for the specific language governing permissions and
# limitations under the License

# [START app_yaml]
# [START gae_std_headless_chrome_app_yaml]
runtime: nodejs10
instance_class: F4_1G
# [END app_yaml]
# [END gae_std_headless_chrome_app_yaml]

0 comments on commit 6b290f0

Please sign in to comment.