This repository has been archived by the owner on Jul 22, 2022. It is now read-only.
Add status as part of DecoratorController hook response #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enisoc
reviewed
Oct 30, 2018
| (syncResult.Finalized && dynamicobject.HasFinalizer(parent, c.finalizer.Name)) { | ||
| updatedParent.SetLabels(parentLabels) | ||
| updatedParent.SetAnnotations(parentAnnotations) | ||
| k8s.SetNestedField(updatedParent.Object, syncResult.Status, "status") |
There was a problem hiding this comment.
Now that we support /status subresource, we need to call UpdateStatus separately if /status is enabled on a given resource. The regular Update call will ignore changes to .status on the server-side in that case.
I think we need something like this:
Suggested change
| k8s.SetNestedField(updatedParent.Object, syncResult.Status, "status") | |
| k8s.SetNestedField(updatedParent.Object, syncResult.Status, "status") | |
| if statusChanged && parentClient.HasSubresource("status") { | |
| // The regular Update below will ignore changes to .status so we do it separately. | |
| result, err := parentClient.Namespace(parent.GetNamespace()).UpdateStatus(updatedParent) | |
| if err != nil { | |
| return fmt.Errorf("can't update status: %v", err) | |
| } | |
| // The Update below needs to use the latest ResourceVersion. | |
| updatedParent.SetResourceVersion(result.GetResourceVersion()) | |
| } |
There was a problem hiding this comment.
There is a typo: result, err := .... Not sure if I can edit it directly in github.
There was a problem hiding this comment.
Ah good catch. I'll fix that in a new suggested change. I think you just did a code review of my code review... This is a strange new world we live in.
Co-Authored-By: lionelvillard <villard@us.ibm.com>
Co-Authored-By: lionelvillard <villard@us.ibm.com>
Co-Authored-By: lionelvillard <villard@us.ibm.com>
Co-Authored-By: lionelvillard <villard@us.ibm.com>
Co-Authored-By: lionelvillard <villard@us.ibm.com>
|
@enisoc it should be good now. Thanks for the fixes! |
enisoc
reviewed
Oct 31, 2018
|
|
||
| if statusChanged && parentClient.HasSubresource("status") { | ||
| // The regular Update below will ignore changes to .status so we do it separately. | ||
| result, err = parentClient.Namespace(parent.GetNamespace()).UpdateStatus(updatedParent) |
There was a problem hiding this comment.
Suggested change
| result, err = parentClient.Namespace(parent.GetNamespace()).UpdateStatus(updatedParent) | |
| result, err := parentClient.Namespace(parent.GetNamespace()).UpdateStatus(updatedParent) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be consistent with CompositeController the status returned by the hook replaces the existing one