Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display default provider values at plan-time #8569

Conversation

NickElliot
Copy link
Contributor

fixes hashicorp/terraform-provider-google#11339

b/292546148

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 300 files changed, 1498 insertions(+), 53 deletions(-))
Terraform Beta: Diff ( 349 files changed, 1739 insertions(+), 53 deletions(-))
TF Conversion: Diff ( 3 files changed, 106 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2921
Passed tests 2615
Skipped tests: 303
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccRedisInstance_regionFromLocation|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccServiceNetworkingPeeredDNSDomain_basic[Error message] [Debug log]
TestAccRedisInstance_regionFromLocation[Error message] [Debug log]
TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 300 files changed, 1509 insertions(+), 53 deletions(-))
Terraform Beta: Diff ( 349 files changed, 1750 insertions(+), 53 deletions(-))
TF Conversion: Diff ( 3 files changed, 117 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2923
Passed tests 2617
Skipped tests: 305
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccRedisInstance_regionFromLocation

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccRedisInstance_regionFromLocation[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@NickElliot NickElliot marked this pull request as ready for review August 9, 2023 20:22
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 300 files changed, 1507 insertions(+), 53 deletions(-))
Terraform Beta: Diff ( 349 files changed, 1748 insertions(+), 53 deletions(-))
TF Conversion: Diff ( 3 files changed, 117 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2923
Passed tests 2618
Skipped tests: 305
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the 5.0 part. May need to rebase on top of the FEATURE-BRANCH-major-release-5.0.0 branch if it runs into merge conflicts in the future but it looks good for now. Pass this to @rileykarson for a close review of the feature

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 296 files changed, 1457 insertions(+), 53 deletions(-))
Terraform Beta: Diff ( 346 files changed, 1703 insertions(+), 53 deletions(-))
TF Conversion: Diff ( 3 files changed, 87 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2946
Passed tests 2639
Skipped tests: 307
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3002
Passed tests 2700
Skipped tests: 301
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataSourceGoogleServiceAccountJwt

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleServiceAccountJwt[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 300 files changed, 2185 insertions(+), 53 deletions(-))
Terraform Beta: Diff ( 355 files changed, 2457 insertions(+), 53 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3002
Passed tests 2684
Skipped tests: 301
Affected tests: 17

Action taken

Found 17 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccLoggingLinkedDataset_loggingLinkedDatasetAllParamsExample|TestAccLoggingLinkedDataset_loggingLinkedDatasetBasicExample|TestAccLoggingLogView_loggingLogViewLongNameExample|TestAccLoggingLogView_loggingLogViewBasicExample|TestAccLoggingBucketConfigProject_cmekSettings|TestAccLoggingBucketConfigProject_basic|TestAccLoggingMetric_loggingBucket|TestAccLoggingBucketConfigProject_locked|TestAccLoggingBucketConfigProject_analyticsEnabled|TestAccLoggingMetric_loggingMetricLoggingBucketExample|TestAccLoggingBucketConfig_CreateBuckets_withCustomId|TestAccLoggingLogView_loggingLogViewBasicExampleUpdate|TestAccResourceGoogleProjectDefaultServiceAccountsDeprivilege|TestAccResourceGoogleProjectDefaultServiceAccountsBasic|TestAccResourceGoogleProjectDefaultServiceAccountsDelete|TestAccResourceGoogleProjectDefaultServiceAccountsDeleteRevertIgnoreFailure|TestAccResourceGoogleProjectDefaultServiceAccountsDisable

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccLoggingLinkedDataset_loggingLinkedDatasetAllParamsExample[Error message] [Debug log]
TestAccLoggingLinkedDataset_loggingLinkedDatasetBasicExample[Error message] [Debug log]
TestAccLoggingLogView_loggingLogViewLongNameExample[Error message] [Debug log]
TestAccLoggingLogView_loggingLogViewBasicExample[Error message] [Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Error message] [Debug log]
TestAccLoggingBucketConfigProject_basic[Error message] [Debug log]
TestAccLoggingMetric_loggingBucket[Error message] [Debug log]
TestAccLoggingBucketConfigProject_locked[Error message] [Debug log]
TestAccLoggingBucketConfigProject_analyticsEnabled[Error message] [Debug log]
TestAccLoggingMetric_loggingMetricLoggingBucketExample[Error message] [Debug log]
TestAccLoggingBucketConfig_CreateBuckets_withCustomId[Error message] [Debug log]
TestAccLoggingLogView_loggingLogViewBasicExampleUpdate[Error message] [Debug log]
TestAccResourceGoogleProjectDefaultServiceAccountsDeprivilege[Error message] [Debug log]
TestAccResourceGoogleProjectDefaultServiceAccountsBasic[Error message] [Debug log]
TestAccResourceGoogleProjectDefaultServiceAccountsDelete[Error message] [Debug log]
TestAccResourceGoogleProjectDefaultServiceAccountsDeleteRevertIgnoreFailure[Error message] [Debug log]
TestAccResourceGoogleProjectDefaultServiceAccountsDisable[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field project became Computed only on google_logging_project_bucket_config - reference
  • Field project became Computed only on google_project_default_service_accounts - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 300 files changed, 2187 insertions(+), 53 deletions(-))
Terraform Beta: Diff ( 355 files changed, 2459 insertions(+), 53 deletions(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change Detection Failed

The breaking change detector crashed during execution. This is usually due to the downstream provider(s) failing to compile. Please investigate or follow up with your reviewer.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 300 files changed, 2177 insertions(+), 53 deletions(-))
Terraform Beta: Diff ( 355 files changed, 2449 insertions(+), 53 deletions(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 298 files changed, 2175 insertions(+), 53 deletions(-))
Terraform Beta: Diff ( 353 files changed, 2447 insertions(+), 53 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3002
Passed tests 2701
Skipped tests: 301
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@NickElliot
Copy link
Contributor Author

@rileykarson Think all looks good with the final error testing?

@rileykarson
Copy link
Member

Yeah, looks reasonable- we removed the customizediff from those resources because the project was a required field.

@NickElliot
Copy link
Contributor Author

Then I'll go ahead and merge it soon -- I don't think any user guide update is needed since it shouldn't require any config updates

@rileykarson
Copy link
Member

We should still cover this in the upgrade guide, describing the changes!

@NickElliot
Copy link
Contributor Author

I'm about to put together the upgrade guide for the 404, so I'll double up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants