-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display default provider values at plan-time #8569
Display default provider values at plan-time #8569
Conversation
…URL parameters of these fields
…ngs previously not caught
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 300 files changed, 1498 insertions(+), 53 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccServiceNetworkingPeeredDNSDomain_basic|TestAccRedisInstance_regionFromLocation|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic |
|
…mputed value from another resource
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 300 files changed, 1509 insertions(+), 53 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccRedisInstance_regionFromLocation |
|
…ase functionality e.g. redis instance
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 300 files changed, 1507 insertions(+), 53 deletions(-)) |
Tests analyticsTotal tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the 5.0 part. May need to rebase on top of the FEATURE-BRANCH-major-release-5.0.0
branch if it runs into merge conflicts in the future but it looks good for now. Pass this to @rileykarson for a close review of the feature
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 296 files changed, 1457 insertions(+), 53 deletions(-)) |
Tests analyticsTotal tests:
|
…jor-release-5.0.0' into v5branch
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataSourceGoogleServiceAccountJwt |
Rerun these tests in REPLAYING mode to catch issues
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 300 files changed, 2185 insertions(+), 53 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 17 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccLoggingLinkedDataset_loggingLinkedDatasetAllParamsExample|TestAccLoggingLinkedDataset_loggingLinkedDatasetBasicExample|TestAccLoggingLogView_loggingLogViewLongNameExample|TestAccLoggingLogView_loggingLogViewBasicExample|TestAccLoggingBucketConfigProject_cmekSettings|TestAccLoggingBucketConfigProject_basic|TestAccLoggingMetric_loggingBucket|TestAccLoggingBucketConfigProject_locked|TestAccLoggingBucketConfigProject_analyticsEnabled|TestAccLoggingMetric_loggingMetricLoggingBucketExample|TestAccLoggingBucketConfig_CreateBuckets_withCustomId|TestAccLoggingLogView_loggingLogViewBasicExampleUpdate|TestAccResourceGoogleProjectDefaultServiceAccountsDeprivilege|TestAccResourceGoogleProjectDefaultServiceAccountsBasic|TestAccResourceGoogleProjectDefaultServiceAccountsDelete|TestAccResourceGoogleProjectDefaultServiceAccountsDeleteRevertIgnoreFailure|TestAccResourceGoogleProjectDefaultServiceAccountsDisable |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 300 files changed, 2187 insertions(+), 53 deletions(-)) |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change Detection FailedThe breaking change detector crashed during execution. This is usually due to the downstream provider(s) failing to compile. Please investigate or follow up with your reviewer. Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 300 files changed, 2177 insertions(+), 53 deletions(-)) |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 298 files changed, 2175 insertions(+), 53 deletions(-)) |
Tests analyticsTotal tests:
|
@rileykarson Think all looks good with the final error testing? |
Yeah, looks reasonable- we removed the customizediff from those resources because the project was a required field. |
Then I'll go ahead and merge it soon -- I don't think any user guide update is needed since it shouldn't require any config updates |
ae21b64
into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-5.0.0
We should still cover this in the upgrade guide, describing the changes! |
I'm about to put together the upgrade guide for the 404, so I'll double up |
fixes hashicorp/terraform-provider-google#11339
b/292546148
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)