Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copyright headers to files in .teamcity/ #8373

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

SarahFrench
Copy link
Collaborator

@SarahFrench SarahFrench commented Jul 18, 2023

Addresses these automated PRs:

Also this PR changes a misleading comment about what days of the week the build configurations are triggered on

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 12 files changed, 62 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 12 files changed, 62 insertions(+), 1 deletion(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@SarahFrench SarahFrench force-pushed the add-copyright-to-teamcity-config branch from dda29da to 68803d0 Compare July 21, 2023 13:45
@SarahFrench
Copy link
Collaborator Author

Just rebased to solve some merge conflicts. I'm going to save merging this PR until after other PRs have been merged, as I don't want to create merge conflicts in more important PRs!

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 10 files changed, 51 insertions(+))
Terraform Beta: Diff ( 10 files changed, 51 insertions(+))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@SarahFrench
Copy link
Collaborator Author

I'm going to save merging this PR until after other PRs have been merged, as I don't want to create merge conflicts in more important PRs!

Not a problem currently, so merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants