-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split customize_diff, schema_version, and migrate_state from resource definition files #8203
split customize_diff, schema_version, and migrate_state from resource definition files #8203
Conversation
…on usage, and support directly included migrate_state and customize_diff functions
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 290 files changed, 882 insertions(+), 22 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccFolderIamPolicy_basic|TestAccComputeNetworkEndpoints_networkEndpointsBasic|TestAccComputeFirewallPolicyRule_multipleRules |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 26 files changed, 81 insertions(+), 22 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeNetworkEndpoints_networkEndpointsBasic|TestAccComputeFirewallPolicyRule_multipleRules |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new attributes make sense to me and the resulting diffs look good. LGTM
Going to move the migrate_state and custom_diff blocks out of custom_code at Riley's suggestion |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 26 files changed, 81 insertions(+), 22 deletions(-)) |
Same diffs produced, will merge soon. |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeNetworkEndpoints_networkEndpointsBasic|TestAccComputeFirewallPolicyRule_multipleRules |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
… definition files (GoogleCloudPlatform#8203) updated yaml parser and generator to offer more flexible schema_version usage, and support directly included migrate_state and customize_diff functions
… definition files (GoogleCloudPlatform#8203) updated yaml parser and generator to offer more flexible schema_version usage, and support directly included migrate_state and customize_diff functions
… definition files (GoogleCloudPlatform#8203) updated yaml parser and generator to offer more flexible schema_version usage, and support directly included migrate_state and customize_diff functions
Removes all but one resource_definition file and adds new custom_code attributes for mentioning custom_diff and migrate_state functions directly. To preserve the current functionality of schema_version when included .yaml schemas, a new attribute boolean has been added called "state_upgraders" for when that version compatibility feature needs to be used with the schema.
Work is required to remove a blocker on hashicorp/terraform-provider-google#11339 for resources that have existing customize_diff functions.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)