Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update google golang api to v0.114.0 to support oauth2 token exchange over mTLS #7485

Merged
merged 3 commits into from
Mar 18, 2023

Conversation

andyrzhao
Copy link
Contributor

@andyrzhao andyrzhao commented Mar 17, 2023

Update google golang api to v0.114.0 to support oauth2 token exchange over mTLS

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.
updated google golang api to v0.114.0 to support oauth2 token exchange over mTLS

@slevenick
Copy link
Contributor

/gcbrun

removed terraform-plugin-go from indirect dependencies,
@rileykarson
Copy link
Member

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 30 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 2 files changed, 30 insertions(+), 10 deletions(-))
TF Validator: Diff ( 2 files changed, 45 insertions(+), 45 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2503
Passed tests 2238
Skipped tests: 263
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccFirebaserulesRelease_BasicRelease|TestAccDataSourceDnsManagedZone_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like no changes to any resource behaviors, good to go

@slevenick slevenick merged commit 6e9bed9 into GoogleCloudPlatform:main Mar 18, 2023
dannawang0221 pushed a commit to dannawang0221/magic-modules that referenced this pull request Mar 24, 2023
…hange over mTLS (GoogleCloudPlatform#7485)

* fix: Update google golang api to v0.114.0 to support oauth2 token exchange over mTLS

* Resolve merge conflict

removed terraform-plugin-go from indirect dependencies,
ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
…hange over mTLS (GoogleCloudPlatform#7485)

* fix: Update google golang api to v0.114.0 to support oauth2 token exchange over mTLS

* Resolve merge conflict

removed terraform-plugin-go from indirect dependencies,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants