Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support SPOT for secondary worker. #7000

Merged
merged 4 commits into from
Dec 22, 2022
Merged

support SPOT for secondary worker. #7000

merged 4 commits into from
Dec 22, 2022

Conversation

duqDarren
Copy link
Contributor

Support 'SPOT' under preemptibility for secondary worker.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

dataproc: added support for `SPOT` option for `preemptibility` in `google_dataproc_cluster`

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @trodge, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.


@melinath
Copy link
Member

melinath commented Dec 19, 2022

@trodge Note: we will not be able to merge this as-is because it adds the field to the GA provider.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 58 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 1 file changed, 1 insertion(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@trodge
Copy link
Contributor

trodge commented Dec 20, 2022

@trodge Note: we will not be able to merge this as-is because it adds the field to the GA provider.

It does look like the API supports this enum value only at GA and not at beta. Are we asking the API team to add beta support as well?

@melinath
Copy link
Member

yep

@duqDarren
Copy link
Contributor Author

@trodge @melinath
#7002 deprecated the v1beta2.
I also removed the version guard from this PR.

@melinath
Copy link
Member

melinath commented Dec 21, 2022

Great! @trodge feel free to assign me as the secondary reviewer when you're done.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 58 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 3 files changed, 58 insertions(+), 1 deletion(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2368
Passed tests 2118
Skipped tests: 247
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccDataprocCluster_spotSecondary|TestAccContainerCluster_withInvalidGatewayApiConfigChannel|TestAccLoggingBucketConfigProject_cmekSettings

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccContainerCluster_withInvalidGatewayApiConfigChannel[Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]

Tests failed during RECORDING mode:
TestAccDataprocCluster_spotSecondary[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 58 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 3 files changed, 58 insertions(+), 1 deletion(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2371
Passed tests 2121
Skipped tests: 247
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccLoggingBucketConfigProject_cmekSettings|TestAccDataprocCluster_spotSecondary|TestAccContainerCluster_withInvalidGatewayApiConfigChannel

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccDataprocCluster_spotSecondary[Debug log]
TestAccContainerCluster_withInvalidGatewayApiConfigChannel[Debug log]

All tests passed
View the build log or the debug log for each test

@trodge trodge requested a review from melinath December 22, 2022 18:56
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 58 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 3 files changed, 58 insertions(+), 1 deletion(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

Copy link
Contributor

@trodge trodge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added @melinath as a secondary reviewer.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2374
Passed tests 2123
Skipped tests: 248
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccLoggingBucketConfigProject_cmekSettings|TestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_withInvalidGatewayApiConfigChannel

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccContainerCluster_withInvalidGatewayApiConfigChannel[Debug log]

All tests passed
View the build log or the debug log for each test

@melinath melinath dismissed trodge’s stale review December 22, 2022 22:31

dismissing due to later lgtm

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems extremely straightforward.

rlapin-pl pushed a commit to rlapin-pl/magic-modules that referenced this pull request Jan 1, 2023
* support SPOT for secondary worker.

* remove version guard for SPOT

* rerun

* remove trailing space
kimihrr pushed a commit to kimihrr/kimiah-magic-modules that referenced this pull request Jan 3, 2023
* support SPOT for secondary worker.

* remove version guard for SPOT

* rerun

* remove trailing space
i-laird pushed a commit to i-laird/magic-modules that referenced this pull request Jan 10, 2023
* support SPOT for secondary worker.

* remove version guard for SPOT

* rerun

* remove trailing space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants