Add IAM to DNS managed Zone, change DNS name for failed tests in quic…

[hao-nan-li]

…kstart.tf

Add IAM to DNS managed Zone, change DNS name for failed tests in quickstartExample

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

Add IAM to DNS managed Zone, change DNS name for failed tests in quickstartExample

[melinath]

what happened to the googlecloudexample.com DNS zone? Can we recover it rather than changing the one we're testing against?

[hao-nan-li]

From https://domains.google.com/registrar/search?hl=en&utm_campaign=2015--na-cloudhelpcenter&utm_content=help%20center&utm_medium=ipm&utm_source=cloudhelpcenter&_ga=2.205012758.769283686.1669661030-440687623.1669661030&searchTerm=googlecloudexample.com&tab=1, it looks like this domain is already registered, and unavailable.

[hao-nan-li]

Riley agreed with changing the domain name. It doesn't seem easy to own domains to run tests.

[melinath]

What will the impact of this change be? For example, will this test end up purchasing the DNS?

[hao-nan-li]

I don't think we purchase the DNS with this test. According to the test, it looks like a compute instance will be created as a web server, reachable through port 80. Finally an IP address will be registered under the DNS.

Since there is a deletion at the end of the test, the IP and the port will be used for about 2-5 minutes (Tested locally).

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 805 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 5 files changed, 805 insertions(+), 3 deletions(-))
TF Validator: Diff ( 5 files changed, 325 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 2332
Passed tests 2082
Skipped tests: 244
Failed tests: 6

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccDNSManagedZoneIamPolicyGenerated|TestAccDNSManagedZoneIamMemberGenerated|TestAccDNSManagedZoneIamBindingGenerated|TestAccDNSManagedZone_dnsManagedZoneQuickstartExample|TestAccLoggingBucketConfigProject_cmekSettings

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccDNSManagedZoneIamPolicyGenerated[Debug log]
TestAccDNSManagedZoneIamMemberGenerated[Debug log]
TestAccDNSManagedZoneIamBindingGenerated[Debug log]
TestAccDNSManagedZone_dnsManagedZoneQuickstartExample[Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]

All tests passed
View the build log or the debug log for each test

[DrFaust92]

hao-nan-li melinath any news on this?