Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Terraform]: Add support for accelerators to dataproc. #688

Merged

Conversation

rileykarson
Copy link
Member

Fixes hashicorp/terraform-provider-google#1985


[all]

[terraform]

Add support for accelerators to dataproc

[terraform-beta]

[ansible]

[inspec]

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#90
depends: hashicorp/terraform-provider-google#2411
depends: modular-magician/inspec-gcp#25

provider/terraform/resources/resource_dataproc_cluster.go Outdated Show resolved Hide resolved
provider/terraform/tests/resource_dataproc_cluster_test.go Outdated Show resolved Hide resolved
@@ -239,6 +265,17 @@ The `cluster_config.master_config` block supports:
* `disk_config.num_local_ssds` - (Optional) The amount of local SSD disks that will be
attached to each master cluster node. Defaults to 0.

* `accelerators` (Optional) The Compute Engine accelerator (GPU) configuration for these instances. Can be specified multiple times.

* `accelerators.accelerator_type` - (Required) Full URL, partial URI, or short name of the accelerator type resource to expose to this instance.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I don't know how I feel about accelerators.accelerator_type since that's not actually a way that you'd be able to reference it (maybe just accelerators.[*].accelerator_type or something like that)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure - I was copying other fields in this file, but they were inconsistent anyways. I got rid of all the prefixes.

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 45b74d7) have been included in your existing downstream PRs.

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 6e7ef89) have been included in your existing downstream PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants