Bigtable: Compare column family #6422

kevinsi4508 · 2022-08-17T14:53:15Z

Fix comparing the wrong name when reading a GC policy.

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

bigtable: fixed comparing column family name when reading a GC policy.

modular-magician · 2022-08-17T14:53:30Z

Oops! It looks like no changelog entry is attached to this PR. Please include a release note block in the PR body, as described in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md:

```release-note:TYPE
Release note
```

modular-magician · 2022-08-17T14:54:15Z

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @melinath, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

Ensuring it's backwards compatible, covers common error cases, etc.
Summarizing the change into a user-facing changelog note.
Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

kevinsi4508 · 2022-08-17T15:01:41Z

@hoangpham95 , please take a look.

modular-magician · 2022-08-17T15:05:21Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 2 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 1 file changed, 2 insertions(+), 1 deletion(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-08-17T15:46:25Z

Tests analytics

Total tests: 2134
Passed tests 1899
Skipped tests: 227
Failed tests: 8

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeInstance_networkPerformanceConfig|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample|TestAccCloudFunctions2Function_fullUpdate|TestAccCloudRunService_cloudRunServiceStaticOutboundExample

modular-magician · 2022-08-17T15:54:12Z

Tests passed during RECORDING mode:
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]
TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample[view]
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample[view]
TestAccCloudFunctions2Function_fullUpdate[view]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[view]
TestAccComputeInstance_networkPerformanceConfig[view]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[view]
TestAccCloudRunService_cloudRunServiceStaticOutboundExample[view]

Please fix these to complete your PR
View the build log or the debug log for each test

melinath

Please update your release note according to the release note authoring guide.

It looks like we have integration tests for this resource which failed to catch this bug. Please update them so that we'll be able to catch any future regressions.

I think that adding an ImportState / ImportStateVerify section should be sufficient - since that would automatically check whether the end state matches what's expected - but there's probably a reason those weren't put in place originally.

Alternately, you could modify the existing Check func to be able to verify the value of - I guess of the resource id?

What is the current observed behavior? Is there a bug or feature request that this PR is related to?

Docs on writing tests:

kevinsi4508 · 2022-08-19T12:01:55Z

Yes, the tracking bug is b/230626815.

Basically the read and diffing parts are broken.

For this PR, I the only different is the Id is set after the read: d.SetId(fi.GCPolicy). There are other PRs are coming.

Let me check if I can verify the Id field.

kevinsi4508 · 2022-08-19T12:55:29Z

Yes, the tracking bug is b/230626815.

Basically the read and diffing parts are broken.

For this PR, I the only different is the Id is set after the read: d.SetId(fi.GCPolicy). There are other PRs are coming.

Let me check if I can verify the Id field.

I am not certain why ImportState: true, ImportStateVerify: true, are not there and instead we only have some composite check functions.

kevinsi4508 · 2022-08-19T13:01:18Z

Yes, the tracking bug is b/230626815.
Basically the read and diffing parts are broken.
For this PR, I the only different is the Id is set after the read: d.SetId(fi.GCPolicy). There are other PRs are coming.
Let me check if I can verify the Id field.

I am not certain why ImportState: true, ImportStateVerify: true, are not there and instead we only have some composite check functions.

Also, there seems to be doing two reads: c.TableInfo(ctx, tableName)

resourceBigtableGCPolicyUpsert()
on in return resourceBigtableGCPolicyRead(d, meta).

Seems to be wrong/redundant.

kevinsi4508 · 2022-08-19T13:03:55Z

Yes, the tracking bug is b/230626815.
Basically the read and diffing parts are broken.
For this PR, I the only different is the Id is set after the read: d.SetId(fi.GCPolicy). There are other PRs are coming.
Let me check if I can verify the Id field.

I am not certain why ImportState: true, ImportStateVerify: true, are not there and instead we only have some composite check functions.

Also, there seems to be doing two reads: c.TableInfo(ctx, tableName)

resourceBigtableGCPolicyUpsert()

on in return resourceBigtableGCPolicyRead(d, meta).

Seems to be wrong/redundant.

Ok, I added the following test case:

func TestAccBigtableGCPolicy_simpleGcRulesPolicy(t *testing.T) {
	skipIfVcr(t)
	t.Parallel()

	instanceName := fmt.Sprintf("tf-test-%s", randString(t, 10))
	tableName := fmt.Sprintf("tf-test-%s", randString(t, 10))
	familyName := fmt.Sprintf("tf-test-%s", randString(t, 10))

	vcrTest(t, resource.TestCase{
		PreCheck:     func() { testAccPreCheck(t) },
		Providers:    testAccProviders,
		CheckDestroy: testAccCheckBigtableGCPolicyDestroyProducer(t),
		Steps: []resource.TestStep{
			{
				Config: testAccBigtableGCPolicy_gcRulesCreate(instanceName, tableName, familyName),
			},
			{
				ResourceName:      "google_bigtable_gc_policy.policy",
				ImportState:       true,
				ImportStateVerify: true,
			},
		},
	})
}

The test failed with this error:

2022-08-19T12:59:47.055Z [ERROR] sdk.helper_resource: Error running import: test_name=TestAccBigtableGCPolicy_simpleGcRulesPolicy test_step_number=2 test_terraform_path=/usr/local/bin/terraform test_working_directory=/tmp/plugintest532077042
  error=
  | exit status 1
  | 
  | Error: resource google_bigtable_gc_policy doesn't support import
  | 
  |

provider_test.go:301: Step 2/2 error running import: exit status 1
    
    Error: resource google_bigtable_gc_policy doesn't support import

I don't understand why GC policy doesn't support import. Maybe we can deal with it separately.

modular-magician · 2022-08-19T13:06:53Z

Oops! It looks like no changelog entry is attached to this PR. Please include a release note block in the PR body, as described in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md:

```release-note:TYPE
Release note
```

modular-magician · 2022-08-19T13:18:35Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 3 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 2 files changed, 3 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

kevinsi4508 · 2022-08-19T13:44:56Z

Yes, the tracking bug is b/230626815.
Basically the read and diffing parts are broken.
For this PR, I the only different is the Id is set after the read: d.SetId(fi.GCPolicy). There are other PRs are coming.
Let me check if I can verify the Id field.

I am not certain why ImportState: true, ImportStateVerify: true, are not there and instead we only have some composite check functions.

Also, there seems to be doing two reads: c.TableInfo(ctx, tableName)

resourceBigtableGCPolicyUpsert()

on in return resourceBigtableGCPolicyRead(d, meta).

Seems to be wrong/redundant.

Ok, I added the following test case:
func TestAccBigtableGCPolicy_simpleGcRulesPolicy(t *testing.T) {
	skipIfVcr(t)
	t.Parallel()

	instanceName := fmt.Sprintf("tf-test-%s", randString(t, 10))
	tableName := fmt.Sprintf("tf-test-%s", randString(t, 10))
	familyName := fmt.Sprintf("tf-test-%s", randString(t, 10))

	vcrTest(t, resource.TestCase{
		PreCheck:     func() { testAccPreCheck(t) },
		Providers:    testAccProviders,
		CheckDestroy: testAccCheckBigtableGCPolicyDestroyProducer(t),
		Steps: []resource.TestStep{
			{
				Config: testAccBigtableGCPolicy_gcRulesCreate(instanceName, tableName, familyName),
			},
			{
				ResourceName:      "google_bigtable_gc_policy.policy",
				ImportState:       true,
				ImportStateVerify: true,
			},
		},
	})
}
The test failed with this error:
2022-08-19T12:59:47.055Z [ERROR] sdk.helper_resource: Error running import: test_name=TestAccBigtableGCPolicy_simpleGcRulesPolicy test_step_number=2 test_terraform_path=/usr/local/bin/terraform test_working_directory=/tmp/plugintest532077042
  error=
  | exit status 1
  | 
  | Error: resource google_bigtable_gc_policy doesn't support import
  | 
  | 
  
provider_test.go:301: Step 2/2 error running import: exit status 1
    
    Error: resource google_bigtable_gc_policy doesn't support import
I don't understand why GC policy doesn't support import. Maybe we can deal with it separately.

GC policy is not importable for some reason.

modular-magician · 2022-08-19T14:06:44Z

Tests analytics

Total tests: 2137
Passed tests 1892
Skipped tests: 228
Failed tests: 17

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccSqlDatabaseInstance_SqlServerAuditConfig|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_networkPerformanceConfig|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccCloudFunctions2Function_fullUpdate|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample|TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled|TestAccSqlDatabaseInstance_settings_upgrade|TestAccSqlDatabaseInstance_authNets|TestAccSqlDatabaseInstance_basicMSSQL|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccSqlDatabaseInstance_settings_deletionProtection|TestAccSqlDatabaseInstance_basic_with_user_labels

modular-magician · 2022-08-19T15:13:26Z

Tests passed during RECORDING mode:
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeClone[view]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeReplica[view]
TestAccFirebaserulesRelease_BasicRelease[view]
TestAccCloudFunctions2Function_fullUpdate[view]
TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample[view]
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample[view]
TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled[view]
TestAccSqlDatabaseInstance_settings_upgrade[view]
TestAccSqlDatabaseInstance_authNets[view]
TestAccSqlDatabaseInstance_basicMSSQL[view]
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]
TestAccSqlDatabaseInstance_settings_deletionProtection[view]
TestAccSqlDatabaseInstance_basic_with_user_labels[view]

Tests failed during RECORDING mode:
TestAccSqlDatabaseInstance_SqlServerAuditConfig[view]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange[view]
TestAccComputeInstance_networkPerformanceConfig[view]
TestAccComputeInstance_soleTenantNodeAffinities[view]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[view]
TestAccCloudRunService_cloudRunServiceStaticOutboundExample[view]

Please fix these to complete your PR
View the build log or the debug log for each test

melinath · 2022-08-19T18:25:12Z

Regarding why import isn't implemented yet - I found details here: hashicorp/terraform-provider-google#4962 (comment)

if you want to implement import, that would make it easy to automate verifying field values with ImportState and ImportStateVerify - but it doesn't need to be a blocker for this PR. You can add a specific check for the appropriate field value instead.

kevinsi4508 · 2022-08-19T18:47:05Z

b/230626815

That makes sense. The nested GC policy (rules) support is being worked on. The current issue is tracked in b/230626815.

We will likely go with checking the remote GC policy against the local copy in the test first. Later will properly implement import for GC policy (b/243127709).

We are still waiting for PR(s) to properly check the nest GC policy. For now, I added a check to make sure that Primary.ID is set:

&& rs.Primary.ID != ""

melinath

Please update your release note according to the release note authoring guide.

melinath · 2022-08-19T19:01:08Z

mmv1/third_party/terraform/tests/resource_bigtable_gc_policy_test.go

@@ -406,7 +406,7 @@ func testAccBigtableGCPolicyExists(t *testing.T, n string) resource.TestCheckFun
 		}

 		for _, i := range table.FamilyInfos {
-			if i.Name == rs.Primary.Attributes["column_family"] {
+			if i.Name == rs.Primary.Attributes["column_family"] && rs.Primary.ID != "" {


I'm not sure this change does anything - if rs.Primary.ID == "" this func returns an error - so we already know that rs.Primary.ID != "" if we've gotten here.

Since this change is to make d.SetId(fi.GCPolicy) get called in a specific case, could we instead use something like one of the builtin check functions to check the exact value of the id field?

Sure, I will check the value of Primary.ID. It won't be very useful once we set the nested GC policy in JSON format in "gc_rules".

I am going to check the value in the same function instead of using a built-in function.

Done.

modular-magician · 2022-08-19T19:42:13Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 3 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 2 files changed, 3 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-08-19T20:45:21Z

Tests analytics

Total tests: 2139
Passed tests 1900
Skipped tests: 228
Failed tests: 11

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeInstance_networkPerformanceConfig|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccCloudFunctions2Function_fullUpdate|TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccSqlDatabaseInstance_SqlServerAuditConfig|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange

modular-magician · 2022-08-19T21:20:49Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[view]
TestAccCloudFunctions2Function_fullUpdate[view]
TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample[view]
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample[view]
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[view]
TestAccComputeInstance_networkPerformanceConfig[view]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[view]
TestAccCloudRunService_cloudRunServiceStaticOutboundExample[view]
TestAccSqlDatabaseInstance_SqlServerAuditConfig[view]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange[view]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeClone[view]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeReplica[view]

Please fix these to complete your PR
View the build log or the debug log for each test

melinath · 2022-08-22T22:40:15Z

Running tests manually out of paranoia: https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloudBeta_ProviderGoogleCloudBetaMmUpstream/328778 should be fine as long as that passes.

melinath

It looks like the TestAccBigtableGCPolicy_multiplePolicies test is currently failing (and it is a real failure. I can also reproduce it manually.) This wasn't caught by the VCR tests because it skips VCR testing.

The error is:

Error retrieving gc policy. Could not find policy in family tf-test-co80ek8ebh

I think this error message should probably be expanded to also include the value of rs.Primary.ID, which would probably shed light on why it's now failing.

If possible, please run this test manually locally to make sure your fix works before pushing it :-)

kevinsi4508 · 2022-08-24T17:52:53Z

It looks like the TestAccBigtableGCPolicy_multiplePolicies test is currently failing (and it is a real failure. I can also reproduce it manually.) This wasn't caught by the VCR tests because it skips VCR testing.

The error is:
Error retrieving gc policy. Could not find policy in family tf-test-co80ek8ebh
I think this error message should probably be expanded to also include the value of rs.Primary.ID, which would probably shed light on why it's now failing.

If possible, please run this test manually locally to make sure your fix works before pushing it :-)

Thanks! Let me take a look and get back to you.

kevinsi4508 · 2022-08-24T18:29:05Z

Well, TestAccBigtableGCPolicy_multiplePolicies is not valid. We can't apply multiple polices to the same column family. Let me think about what to do with that test case.

kevinsi4508 · 2022-08-24T19:00:18Z

Well, TestAccBigtableGCPolicy_multiplePolicies is not valid. We can't apply multiple polices to the same column family. Let me think about what to do with that test case.

I updated the test case to have multiple GC policy, but one per column family.

modular-magician · 2022-08-24T19:10:19Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 15 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 2 files changed, 15 insertions(+), 7 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-08-24T20:12:52Z

Tests analytics

Total tests: 2144
Passed tests 1903
Skipped tests: 228
Failed tests: 13

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeInstance_networkPerformanceConfig|TestAccCloudFunctions2Function_fullUpdate|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccCloudRunService_cloudRunServiceScheduledExample|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample|TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccCGCSnippet_storageObjectLifecycleSettingExample|TestAccSqlDatabaseInstance_SqlServerAuditConfig|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange

modular-magician · 2022-08-24T20:21:06Z

Tests passed during RECORDING mode:
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample[view]
TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample[view]
TestAccCGCSnippet_eventarcWorkflowsExample[view]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[view]
TestAccComputeInstance_networkPerformanceConfig[view]
TestAccCloudFunctions2Function_fullUpdate[view]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[view]
TestAccCloudRunService_cloudRunServiceScheduledExample[view]
TestAccCloudRunService_cloudRunServiceStaticOutboundExample[view]
TestAccCGCSnippet_storageObjectLifecycleSettingExample[view]
TestAccSqlDatabaseInstance_SqlServerAuditConfig[view]
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange[view]

Please fix these to complete your PR
View the build log or the debug log for each test

melinath · 2022-08-24T20:23:18Z

non-VCR test run: https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloudBeta_ProviderGoogleCloudBetaMmUpstream/329824

melinath

LGTM

* Compare column family when reading a GC policy * revert column family change * Compare column family when reading a GC policy * Check rs.Primary.ID is not empty * Compare Primary.Id with GCPolicy * One GC policy per column family

kevinsi4508 added 3 commits August 17, 2022 14:17

Compare column family when reading a GC policy

047f68a

revert column family change

981389a

Compare column family when reading a GC policy

3acfe62

modular-magician requested a review from melinath August 17, 2022 14:54

kevinsi4508 changed the title ~~Compare column family~~ Bigtable: Compare column family Aug 18, 2022

melinath requested changes Aug 18, 2022

View reviewed changes

Check rs.Primary.ID is not empty

fe2b622

kevinsi4508 requested a review from melinath August 19, 2022 13:07

melinath requested changes Aug 19, 2022

View reviewed changes

Compare Primary.Id with GCPolicy

2c9dc7f

kevinsi4508 requested a review from melinath August 19, 2022 19:31

melinath requested changes Aug 23, 2022

View reviewed changes

One GC policy per column family

4caf672

modular-magician requested a review from melinath August 24, 2022 18:59

melinath approved these changes Aug 24, 2022

View reviewed changes

melinath merged commit d487b27 into GoogleCloudPlatform:main Aug 24, 2022

This was referenced Aug 24, 2022

Bigtable: Compare column family hashicorp/terraform-provider-google-beta#4624

Merged

Bigtable: Compare column family hashicorp/terraform-provider-google#12381

Merged

Bigtable: Compare column family GoogleCloudPlatform/terraform-validator#931

Merged

kevinsi4508 deleted the compare_column_family branch September 6, 2022 13:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bigtable: Compare column family #6422

Bigtable: Compare column family #6422

kevinsi4508 commented Aug 17, 2022 •

edited

Loading

modular-magician commented Aug 17, 2022

modular-magician commented Aug 17, 2022

kevinsi4508 commented Aug 17, 2022

modular-magician commented Aug 17, 2022

modular-magician commented Aug 17, 2022

modular-magician commented Aug 17, 2022

melinath left a comment

kevinsi4508 commented Aug 19, 2022

kevinsi4508 commented Aug 19, 2022

kevinsi4508 commented Aug 19, 2022

kevinsi4508 commented Aug 19, 2022 •

edited

Loading

modular-magician commented Aug 19, 2022

modular-magician commented Aug 19, 2022

kevinsi4508 commented Aug 19, 2022

modular-magician commented Aug 19, 2022

modular-magician commented Aug 19, 2022

melinath commented Aug 19, 2022 •

edited

Loading

kevinsi4508 commented Aug 19, 2022 •

edited

Loading

melinath left a comment

melinath Aug 19, 2022

kevinsi4508 Aug 19, 2022

modular-magician commented Aug 19, 2022

modular-magician commented Aug 19, 2022

modular-magician commented Aug 19, 2022

melinath commented Aug 22, 2022

melinath left a comment •

edited

Loading

kevinsi4508 commented Aug 24, 2022

kevinsi4508 commented Aug 24, 2022

kevinsi4508 commented Aug 24, 2022

modular-magician commented Aug 24, 2022

modular-magician commented Aug 24, 2022

modular-magician commented Aug 24, 2022

melinath commented Aug 24, 2022

melinath left a comment

Bigtable: Compare column family #6422

Bigtable: Compare column family #6422

Conversation

kevinsi4508 commented Aug 17, 2022 • edited Loading

modular-magician commented Aug 17, 2022

modular-magician commented Aug 17, 2022

kevinsi4508 commented Aug 17, 2022

modular-magician commented Aug 17, 2022

Diff report:

modular-magician commented Aug 17, 2022

Tests analytics

Action taken

modular-magician commented Aug 17, 2022

melinath left a comment

Choose a reason for hiding this comment

kevinsi4508 commented Aug 19, 2022

kevinsi4508 commented Aug 19, 2022

kevinsi4508 commented Aug 19, 2022

kevinsi4508 commented Aug 19, 2022 • edited Loading

modular-magician commented Aug 19, 2022

modular-magician commented Aug 19, 2022

Diff report:

kevinsi4508 commented Aug 19, 2022

modular-magician commented Aug 19, 2022

Tests analytics

Action taken

modular-magician commented Aug 19, 2022

melinath commented Aug 19, 2022 • edited Loading

kevinsi4508 commented Aug 19, 2022 • edited Loading

melinath left a comment

Choose a reason for hiding this comment

melinath Aug 19, 2022

Choose a reason for hiding this comment

kevinsi4508 Aug 19, 2022

Choose a reason for hiding this comment

modular-magician commented Aug 19, 2022

Diff report:

modular-magician commented Aug 19, 2022

Tests analytics

Action taken

modular-magician commented Aug 19, 2022

melinath commented Aug 22, 2022

melinath left a comment • edited Loading

Choose a reason for hiding this comment

kevinsi4508 commented Aug 24, 2022

kevinsi4508 commented Aug 24, 2022

kevinsi4508 commented Aug 24, 2022

modular-magician commented Aug 24, 2022

Diff report:

modular-magician commented Aug 24, 2022

Tests analytics

Action taken

modular-magician commented Aug 24, 2022

melinath commented Aug 24, 2022

melinath left a comment

Choose a reason for hiding this comment

kevinsi4508 commented Aug 17, 2022 •

edited

Loading

kevinsi4508 commented Aug 19, 2022 •

edited

Loading

melinath commented Aug 19, 2022 •

edited

Loading

kevinsi4508 commented Aug 19, 2022 •

edited

Loading

melinath left a comment •

edited

Loading