Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove requirement form zone field in composer config.node_config (#10324) #5320

Merged
merged 5 commits into from
Oct 20, 2021

Conversation

kubasieron
Copy link
Contributor

@kubasieron kubasieron commented Oct 14, 2021

Changed configuration of zone field -now it is required and computed as Composer API stands. That allows creating proper composer v2 envs.

fixes hashicorp/terraform-provider-google#10324

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

composer: removed `config.node_config.zone` requirement on `google_composer_environment`

@google-cla google-cla bot added the cla: yes label Oct 14, 2021
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@ScottSuarez, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 36 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 3 files changed, 66 insertions(+), 30 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccComposerEnvironment_basic|TestAccComposerEnvironment_update|TestAccComposerEnvironment_ComposerV2 You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=210629

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccComposerEnvironment_ComposerV2|TestAccComposerEnvironment_basic|TestAccComposerEnvironment_update Please fix these to complete your PR

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 36 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 4 files changed, 68 insertions(+), 32 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComposerEnvironment_basic|TestAccComposerEnvironment_update|TestAccComposerEnvironment_ComposerV2|TestAccContainerCluster_withAddons|TestAccContainerCluster_withWorkloadIdentityConfigDeprecation|TestAccContainerCluster_withWorkloadIdentityConfig You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=211192

Copy link
Contributor

@ScottSuarez ScottSuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused what is happening here, all the code here is commenting various things out?

Comment on lines 21 to 28
// composerEnvironmentV2VersionRegexp = `composer-(2\.[0-9]+\.[0-9]+(-preview\.[0-9]+)?|latest)-airflow-([0-9]+\.[0-9]+(\.[0-9]+.*)?)`
)

//func isComposerV2(imageVersion string) bool {
// regex := regexp.MustCompile(composerEnvironmentV2VersionRegexp)
// return regex.MatchString(imageVersion)
//}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove commented out code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 6 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 3 files changed, 37 insertions(+), 30 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccContainerNodePool_withGPU|TestAccSqlUser_postgresIAM|TestAccTags You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=211406

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccTags|TestAccSqlUser_postgresIAM Please fix these to complete your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Composer zone field in config.node_config shouldn't be required
3 participants