-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove requirement form zone field in composer config.node_config (#10324) #5320
remove requirement form zone field in composer config.node_config (#10324) #5320
Conversation
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @ScottSuarez, please review this PR or find an appropriate assignee. |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccComposerEnvironment_basic|TestAccComposerEnvironment_update|TestAccComposerEnvironment_ComposerV2 You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=210629 |
Tests failed during RECORDING mode: TestAccComposerEnvironment_ComposerV2|TestAccComposerEnvironment_basic|TestAccComposerEnvironment_update Please fix these to complete your PR |
c976aad
to
5f4a50a
Compare
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComposerEnvironment_basic|TestAccComposerEnvironment_update|TestAccComposerEnvironment_ComposerV2|TestAccContainerCluster_withAddons|TestAccContainerCluster_withWorkloadIdentityConfigDeprecation|TestAccContainerCluster_withWorkloadIdentityConfig You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=211192 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused what is happening here, all the code here is commenting various things out?
// composerEnvironmentV2VersionRegexp = `composer-(2\.[0-9]+\.[0-9]+(-preview\.[0-9]+)?|latest)-airflow-([0-9]+\.[0-9]+(\.[0-9]+.*)?)` | ||
) | ||
|
||
//func isComposerV2(imageVersion string) bool { | ||
// regex := regexp.MustCompile(composerEnvironmentV2VersionRegexp) | ||
// return regex.MatchString(imageVersion) | ||
//} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove commented out code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccContainerNodePool_withGPU|TestAccSqlUser_postgresIAM|TestAccTags You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=211406 |
Tests failed during RECORDING mode: TestAccTags|TestAccSqlUser_postgresIAM Please fix these to complete your PR |
Changed configuration of zone field -now it is required and computed as Composer API stands. That allows creating proper composer v2 envs.
fixes hashicorp/terraform-provider-google#10324
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)